Updating Bedrock Converse API citations format to handle web citations #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2025 12:23
Refactor CitationLocation TypedDict to support both web and document citations with optional fields. Add comprehensive unit tests covering all citation types. Fix type errors using cast pattern consistent with existing codebase.
danilop
requested a deployment
to
manual-approval
GitHub Actions
Waiting
client-side tools that need agent execution. This prevents infinite loops when models return end_turn stopReason for server_tool_use types like nova_grounding.
danilop
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for web-based citations in the Bedrock Converse API, enabling the SDK to handle citations from web sources in addition to document-based citations.
Changes:
WebLocationTypedDict tosrc/strands/types/citations.pywithurlanddomainfieldsCitationLocationunion type to include the newWebLocationtypesrc/strands/models/bedrock.pyto handle web-based citationsAll citation location types (document-based and web-based) are now supported as per the updated Bedrock Converse API specification.
Related Issues
This was a blocking issue for #1154
Documentation PR
N/A
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.