small adjustments to SynonymService and HTTPRequester to get rid of exceptions in edge cases

Author: steffenjacobs

src/main/java/me/steffenjacobs/syntacticjsonmatcher/service/SynonymService.java

@@ -1,5 +1,7 @@
 package me.steffenjacobs.syntacticjsonmatcher.service;
 
+import java.io.UnsupportedEncodingException;
+import java.net.URLEncoder;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -28,7 +30,11 @@ public SynonymService() {
 	private String buildRequest(String word) {
 		StringBuilder sb = new StringBuilder();
 		sb.append("https://api.datamuse.com/words?rel_syn=");
-		sb.append(word);
+		try {
+			sb.append(URLEncoder.encode(word, "UTF-8"));
+		} catch (UnsupportedEncodingException e) {
+			LOG.error(e.getMessage());
+		}
 		return sb.toString();
 	}
 
@@ -47,6 +53,10 @@ public Map<String, Integer> findSynonyms(String word) {
 		String request = buildRequest(word);
 		String result = httpRequester.sendGet(request);
 		try {
+			if (result.isEmpty()) {
+				synonymCache.put(word, map);
+				return map;
+			}
 			JSONArray json = new JSONArray(result);
 			if (json.isEmpty()) {
 				synonymCache.put(word, map);

src/main/java/me/steffenjacobs/syntacticjsonmatcher/util/HTTPRequester.java

@@ -33,7 +33,7 @@ public String sendGet(String url) {
 
 			return response.toString();
 		} catch (IOException e) {
-			LOG.error(e.getMessage(), e);
+			LOG.error(e.getMessage());
 			return "";
 		}
 	}

src/test/java/me/steffenjacobs/syntacticjsonmatcher/service/TestSynonymService.java

@@ -5,8 +5,6 @@
 import org.junit.Assert;
 import org.junit.Test;
 
-import me.steffenjacobs.syntacticjsonmatcher.service.SynonymService;
-
 /** @author Steffen Jacobs */
 public class TestSynonymService {
 
@@ -18,4 +16,10 @@ public void testSynonymService() {
 		Assert.assertTrue(result.get("humidness") > 0);
 	}
 
+	@Test
+	public void testSynonymService2() {
+		Map<String, Integer> result = new SynonymService().findSynonyms("air pressure");
+		Assert.assertTrue(result.isEmpty());
+	}
+
 }