From 28ff75309a49a680aa67ab7bfdd66c38d1dac207 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Wed, 10 Jun 2026 02:27:16 -0500 Subject: [PATCH] test: migrate `math/base/special/acovercosf` to ULP-based testing --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../math/base/special/acovercosf/test/test.js | 22 +++---------------- .../special/acovercosf/test/test.native.js | 22 +++---------------- 2 files changed, 6 insertions(+), 38 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.js b/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.js index e0c0c5308c8f..b5007b1dad6f 100644 --- a/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.js @@ -23,9 +23,9 @@ var tape = require( 'tape' ); var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); var randu = require( '@stdlib/random/base/randu' ); -var absf = require( '@stdlib/math/base/special/absf' ); var EPS = require( '@stdlib/constants/float32/eps' ); var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' ); +var isAlmostSameValue = require( '@stdlib/number/float32/base/assert/is-almost-same-value' ); var acovercosf = require( './../lib' ); @@ -45,8 +45,6 @@ tape( 'main export is a function', function test( t ) { tape( 'the function computes the inverse coversed cosine', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -58,21 +56,13 @@ tape( 'the function computes the inverse coversed cosine', function test( t ) { for ( i = 0; i < x.length; i++ ) { e = float64ToFloat32( expected[ i ] ); y = acovercosf( x[ i ] ); - if ( y === e ) { - t.strictEqual( y, e, 'x: '+x[ i ]+'. E: '+e ); - } else { - delta = absf( y - e ); - tol = 230.0 * EPS * absf( e ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, e, 234 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function computes the inverse coversed cosine (small positive numbers)', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -84,13 +74,7 @@ tape( 'the function computes the inverse coversed cosine (small positive numbers for ( i = 0; i < x.length; i++ ) { e = float64ToFloat32( expected[ i ] ); y = acovercosf( x[ i ] ); - if ( y === e ) { - t.strictEqual( y, e, 'x: '+x[ i ]+'. E: '+e ); - } else { - delta = absf( y - e ); - tol = EPS * absf( e ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( y, e, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.native.js index de35b9ff2ce0..7c9978b420ac 100644 --- a/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/acovercosf/test/test.native.js @@ -24,9 +24,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); var randu = require( '@stdlib/random/base/randu' ); -var absf = require( '@stdlib/math/base/special/absf' ); var EPS = require( '@stdlib/constants/float32/eps' ); var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' ); +var isAlmostSameValue = require( '@stdlib/number/float32/base/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -54,8 +54,6 @@ tape( 'main export is a function', opts, function test( t ) { tape( 'the function computes the inverse coversed cosine', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -67,21 +65,13 @@ tape( 'the function computes the inverse coversed cosine', opts, function test( for ( i = 0; i < x.length; i++ ) { e = float64ToFloat32( expected[ i ] ); y = acovercosf( x[ i ] ); - if ( y === e ) { - t.strictEqual( y, e, 'x: '+x[ i ]+'. E: '+e ); - } else { - delta = absf( y - e ); - tol = 230.0 * EPS * absf( e ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, e, 234 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function computes the inverse coversed cosine (small positive numbers)', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -93,13 +83,7 @@ tape( 'the function computes the inverse coversed cosine (small positive numbers for ( i = 0; i < x.length; i++ ) { e = float64ToFloat32( expected[ i ] ); y = acovercosf( x[ i ] ); - if ( y === e ) { - t.strictEqual( y, e, 'x: '+x[ i ]+'. E: '+e ); - } else { - delta = absf( y - e ); - tol = EPS * absf( e ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( y, e, 'returns expected value' ); } t.end(); });