From 8fa863f72db2f7ed2af1426bac2ae2e9498c98a8 Mon Sep 17 00:00:00 2001 From: Philipp Burckhardt Date: Wed, 10 Jun 2026 02:18:08 -0500 Subject: [PATCH] test: migrate `math/base/special/vercos` to ULP-based testing --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../math/base/special/vercos/test/test.js | 62 ++------------- .../base/special/vercos/test/test.native.js | 75 +++++-------------- 2 files changed, 25 insertions(+), 112 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/vercos/test/test.js b/lib/node_modules/@stdlib/math/base/special/vercos/test/test.js index 646321831b06..2ad49b0980ec 100644 --- a/lib/node_modules/@stdlib/math/base/special/vercos/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/vercos/test/test.js @@ -22,10 +22,8 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var vercos = require( './../lib' ); @@ -49,8 +47,6 @@ tape( 'main export is a function', function test( t ) { tape( 'the function computes the versed cosine (for -256*pi < x < 0 )', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -60,13 +56,7 @@ tape( 'the function computes the versed cosine (for -256*pi < x < 0 )', function for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( y, expected[ i ], 'returns expected value' ); } t.end(); @@ -74,8 +64,6 @@ tape( 'the function computes the versed cosine (for -256*pi < x < 0 )', function tape( 'the function computes the versed cosine (for 0 < x < 256*pi )', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -85,13 +73,7 @@ tape( 'the function computes the versed cosine (for 0 < x < 256*pi )', function for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( y, expected[ i ], 'returns expected value' ); } t.end(); @@ -99,8 +81,6 @@ tape( 'the function computes the versed cosine (for 0 < x < 256*pi )', function tape( 'the function computes the versed cosine (for -2**60 (pi/2) < x < -2**20 (pi/2) )', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -110,13 +90,7 @@ tape( 'the function computes the versed cosine (for -2**60 (pi/2) < x < -2**20 ( for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( y, expected[ i ], 'returns expected value' ); } t.end(); @@ -124,8 +98,6 @@ tape( 'the function computes the versed cosine (for -2**60 (pi/2) < x < -2**20 ( tape( 'the function computes the versed cosine (for 2**20 (pi/2) < x < 2**60 (pi/2) )', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -135,13 +107,7 @@ tape( 'the function computes the versed cosine (for 2**20 (pi/2) < x < 2**60 (pi for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( y, expected[ i ], 'returns expected value' ); } t.end(); @@ -149,8 +115,6 @@ tape( 'the function computes the versed cosine (for 2**20 (pi/2) < x < 2**60 (pi tape( 'the function computes the versed cosine (for x <= -2**60 (PI/2) )', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -160,13 +124,7 @@ tape( 'the function computes the versed cosine (for x <= -2**60 (PI/2) )', funct for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( y, expected[ i ], 'returns expected value' ); } t.end(); @@ -174,8 +132,6 @@ tape( 'the function computes the versed cosine (for x <= -2**60 (PI/2) )', funct tape( 'the function computes the versed cosine (for x >= 2**60 (PI/2) )', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -185,13 +141,7 @@ tape( 'the function computes the versed cosine (for x >= 2**60 (PI/2) )', functi for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( y, expected[ i ], 'returns expected value' ); } t.end(); diff --git a/lib/node_modules/@stdlib/math/base/special/vercos/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/vercos/test/test.native.js index a3a40c89d6f1..ce9357a1825d 100644 --- a/lib/node_modules/@stdlib/math/base/special/vercos/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/vercos/test/test.native.js @@ -23,10 +23,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -58,8 +57,6 @@ tape( 'main export is a function', opts, function test( t ) { tape( 'the function computes the versed cosine (for -256*pi < x < 0 )', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -69,13 +66,9 @@ tape( 'the function computes the versed cosine (for -256*pi < x < 0 )', opts, fu for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 2.0 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + + // NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205 + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); @@ -83,8 +76,6 @@ tape( 'the function computes the versed cosine (for -256*pi < x < 0 )', opts, fu tape( 'the function computes the versed cosine (for 0 < x < 256*pi )', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -94,13 +85,9 @@ tape( 'the function computes the versed cosine (for 0 < x < 256*pi )', opts, fun for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 2.0 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + + // NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205 + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); @@ -108,8 +95,6 @@ tape( 'the function computes the versed cosine (for 0 < x < 256*pi )', opts, fun tape( 'the function computes the versed cosine (for -2**60 (pi/2) < x < -2**20 (pi/2) )', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -119,13 +104,9 @@ tape( 'the function computes the versed cosine (for -2**60 (pi/2) < x < -2**20 ( for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 6.5 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + + // NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205 + t.strictEqual( isAlmostSameValue( y, expected[ i ], 8 ), true, 'returns expected value' ); } t.end(); @@ -133,8 +114,6 @@ tape( 'the function computes the versed cosine (for -2**60 (pi/2) < x < -2**20 ( tape( 'the function computes the versed cosine (for 2**20 (pi/2) < x < 2**60 (pi/2) )', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -144,13 +123,9 @@ tape( 'the function computes the versed cosine (for 2**20 (pi/2) < x < 2**60 (pi for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 6.5 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + + // NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205 + t.strictEqual( isAlmostSameValue( y, expected[ i ], 8 ), true, 'returns expected value' ); } t.end(); @@ -158,8 +133,6 @@ tape( 'the function computes the versed cosine (for 2**20 (pi/2) < x < 2**60 (pi tape( 'the function computes the versed cosine (for x <= -2**60 (PI/2) )', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -169,13 +142,9 @@ tape( 'the function computes the versed cosine (for x <= -2**60 (PI/2) )', opts, for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 1.6 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + + // NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205 + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end(); @@ -183,8 +152,6 @@ tape( 'the function computes the versed cosine (for x <= -2**60 (PI/2) )', opts, tape( 'the function computes the versed cosine (for x >= 2**60 (PI/2) )', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -194,13 +161,9 @@ tape( 'the function computes the versed cosine (for x >= 2**60 (PI/2) )', opts, for ( i = 0; i < x.length; i++ ) { y = vercos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 1.6 * EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + + // NOTE: the tolerance here is larger than for the JavaScript implementation due to compiler optimizations which may be performed resulting in result divergence. For discussion, see https://github.com/stdlib-js/stdlib/pull/2298#discussion_r1624765205 + t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' ); } t.end();