move ci checks to scripts (#7766)

* move ci checks to scripts

* no sh

* bash

Author: arnetheduck

.github/workflows/ci.yml

@@ -259,51 +259,11 @@ jobs:
       - name: Check exception tracking
         if: ${{ !cancelled() }} && github.event_name == 'pull_request'
         run: |
-          problematic_files=()
-          while read -r file; do
-            if ! grep -qE '^{\.push raises: \[\](, gcsafe)?\.}$' "$file"; then
-              problematic_files+=("$file")
-            fi
-          done < <(git diff --name-only --diff-filter=AM --ignore-submodules HEAD^ HEAD | grep -E '\.nim$' || true)
-
-          if (( ${#problematic_files[@]} )); then
-            echo "The following files do not have '{.push raises: [], gcsafe.}' (gcsafe optional):"
-            for file in "${problematic_files[@]}"; do
-              echo "- $file"
-            done
-            echo "See https://status-im.github.io/nim-style-guide/errors.exceptions.html"
-            exit 2
-          fi
-
+          scripts/check_exception_headers.sh
       - name: Check submodules
         if: ${{ !cancelled() }} && github.event_name == 'pull_request'
         run: |
-          while read -r file; do
-            commit="$(git -C "$file" rev-parse HEAD)"
-            commit_date=$(TZ=UTC0 git -C "$file" show -s --format='%cd' --date=iso-local HEAD)
-            if ! branch="$(git config -f .gitmodules --get "submodule.$file.branch")"; then
-              echo "Submodule '$file': '.gitmodules' lacks 'branch' entry"
-              exit 2
-            fi
-            # Without the `--depth=1` fetch, may run into 'error processing shallow info: 4'
-            if ! error="$(git -C "$file" fetch -q --depth=1 origin "+refs/heads/${branch}:refs/remotes/origin/${branch}")"; then
-              echo "Submodule '$file': Failed to fetch '$branch': $error (1)"
-              exit 2
-            fi
-            branch_commit_date=$(TZ=UTC0 git -C "$file" show -s --format='%cd' --date=iso-local "refs/remotes/origin/${branch}")
-            if [[ "${commit_date}" > "${branch_commit_date}" ]]; then
-              echo "Submodule '$file': '$commit' ($commit_date) is more recent than latest '$branch' ($branch_commit_date) (branch config: '.gitmodules')"
-              exit 2
-            fi
-            if ! error="$(git -C "$file" fetch -q --shallow-since="$commit_date" origin "+refs/heads/${branch}:refs/remotes/origin/${branch}")"; then
-              echo "Submodule '$file': Failed to fetch '$branch': $error (2)"
-              exit 2
-            fi
-            if ! git -C "$file" merge-base --is-ancestor "$commit" "refs/remotes/origin/$branch"; then
-              echo "Submodule '$file': '$commit' is not on '$branch' as of $commit_date (branch config: '.gitmodules')"
-              exit 2
-            fi
-          done < <(git diff --name-only --diff-filter=AM HEAD^ HEAD | grep -f <(git config --file .gitmodules --get-regexp path | awk '{ print $2 }') || true)
+          scripts/check_submodule_branches.sh
 
   # https://github.com/EnricoMi/publish-unit-test-result-action
   event_file:

scripts/check_exception_headers.sh

@@ -0,0 +1,17 @@
+#!/bin/bash
+
+problematic_files=()
+while read -r file; do
+  if ! grep -qE '^{\.push raises: \[\](, gcsafe)?\.}$' "$file"; then
+    problematic_files+=("$file")
+  fi
+done < <(git diff --name-only --diff-filter=AM --ignore-submodules HEAD^ | grep -E '\.nim$' || true)
+
+if (( ${#problematic_files[@]} )); then
+  echo "The following files do not have '{.push raises: [], gcsafe.}' (gcsafe optional):"
+  for file in "${problematic_files[@]}"; do
+    echo "- $file"
+  done
+  echo "See https://status-im.github.io/nim-style-guide/errors.exceptions.html"
+  exit 2
+fi

scripts/check_submodule_branches.sh

@@ -0,0 +1,28 @@
+#!/bin/bash
+
+while read -r file; do
+  commit="$(git -C "$file" rev-parse HEAD)"
+  commit_date=$(TZ=UTC0 git -C "$file" show -s --format='%cd' --date=iso-local HEAD)
+  if ! branch="$(git config -f .gitmodules --get "submodule.$file.branch")"; then
+    echo "Submodule '$file': '.gitmodules' lacks 'branch' entry"
+    exit 2
+  fi
+  # Without the `--depth=1` fetch, may run into 'error processing shallow info: 4'
+  if ! error="$(git -C "$file" fetch -q --depth=1 origin "+refs/heads/${branch}:refs/remotes/origin/${branch}")"; then
+    echo "Submodule '$file': Failed to fetch '$branch': $error (1)"
+    exit 2
+  fi
+  branch_commit_date=$(TZ=UTC0 git -C "$file" show -s --format='%cd' --date=iso-local "refs/remotes/origin/${branch}")
+  if [[ "${commit_date}" > "${branch_commit_date}" ]]; then
+    echo "Submodule '$file': '$commit' ($commit_date) is more recent than latest '$branch' ($branch_commit_date) (branch config: '.gitmodules')"
+    exit 2
+  fi
+  if ! error="$(git -C "$file" fetch -q --shallow-since="$commit_date" origin "+refs/heads/${branch}:refs/remotes/origin/${branch}")"; then
+    echo "Submodule '$file': Failed to fetch '$branch': $error (2)"
+    exit 2
+  fi
+  if ! git -C "$file" merge-base --is-ancestor "$commit" "refs/remotes/origin/$branch"; then
+    echo "Submodule '$file': '$commit' is not on '$branch' as of $commit_date (branch config: '.gitmodules')"
+    exit 2
+  fi
+done < <(git diff --name-only --diff-filter=AM HEAD^ | grep -f <(git config --file .gitmodules --get-regexp path | awk '{ print $2 }') || true)