fix: address reviews

Author: Tomi-3-0

beacon_chain/validators/action_tracker.nim

@@ -134,21 +134,20 @@ proc registerPTCDuty*(
 
   let newDuty = PTCDuty(slot: slot, validator_index: vidx)
 
-  if newDuty in tracker.ptcDuties:
-    return
-
   debug "Registering PTC duty", slot, vidx
   tracker.ptcDuties.incl(newDuty)
 
-from std/sequtils import toSeq, anyIt
+from std/sequtils import anyIt, toSeq
 
 func hasPTCDuty*(tracker: ActionTracker, slot: Slot): bool =
   tracker.ptcDuties.anyIt(it.slot == slot)
 
 func getPTCDuties*(tracker: ActionTracker, slot: Slot): seq[ValidatorIndex] =
+  var duties: seq[ValidatorIndex]
   for duty in tracker.ptcDuties:
     if duty.slot == slot:
-      result.add(duty.validator_index)
+      duties.add(duty.validator_index)
+  duties
 
 func aggregateSubnets*(tracker: ActionTracker, wallSlot: Slot): AttnetBits =
   var res: AttnetBits

beacon_chain/validators/beacon_validators.nim

@@ -1286,14 +1286,18 @@ proc registerPTCDuties(node: BeaconNode, epoch: Epoch) =
   if node.dag.cfg.consensusForkAtEpoch(epoch) < ConsensusFork.Gloas:
     return
 
-  let validatorIndices = toHashSet(toSeq(node.attachedValidators[].indices()))
+  let validatorIndices = block:
+    var res: HashSet[ValidatorIndex]
+    for idx in node.attachedValidators[].indices():
+      res.incl(idx)
+    res
 
   withState(node.dag.headState):
     when consensusFork >= ConsensusFork.Gloas:
-      var cache = new StateCache
+      var cache: StateCache
 
       for slot in epoch.slots():
-        for validator_index in get_ptc(forkyState.data, slot, cache[]):
+        for validator_index in get_ptc(forkyState.data, slot, cache):
           if validator_index in validatorIndices:
             node.consensusManager[].actionTracker.registerPTCDuty(
               slot, validator_index)