Skip to content

Commit a7e1959

Browse files
authored
Merge pull request #57 from InvestmentSystems/minor-improvements-to-decref-in-deep-copy
Update dtype references when creation of new array fails
2 parents 5133c7c + 7d6f8a4 commit a7e1959

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/_arraykit.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -198,11 +198,12 @@ AK_ArrayDeepCopy(PyArrayObject *array, PyObject *memo)
198198
array,
199199
dtype,
200200
NPY_ARRAY_ENSURECOPY);
201-
if (memo) {
202-
if (!array_new || PyDict_SetItem(memo, id, array_new)) {
203-
Py_XDECREF(array_new);
204-
goto error;
205-
}
201+
if (!array_new) {
202+
goto error;
203+
}
204+
if (memo && PyDict_SetItem(memo, id, array_new)) {
205+
Py_DECREF(array_new);
206+
goto error;
206207
}
207208
}
208209
// set immutable

0 commit comments

Comments
 (0)