Move all of /pkg under /internal (#105)

Nothing in /pkg at present needs to be importable in other projects.
Move everything into internal.

This is a big PR, but all changes are to do with moving files. There are
no changes to the logic.

Author: dmjb

cmd/thv-registry-api/app/commands.go

@@ -9,7 +9,7 @@ import (
 	"github.com/spf13/viper"
 	"github.com/stacklok/toolhive/pkg/logger"
 
-	"github.com/stacklok/toolhive-registry-server/pkg/versions"
+	"github.com/stacklok/toolhive-registry-server/internal/versions"
 )
 
 var rootCmd = &cobra.Command{

cmd/thv-registry-api/app/serve.go

@@ -14,8 +14,8 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 
-	registryapp "github.com/stacklok/toolhive-registry-server/pkg/app"
-	"github.com/stacklok/toolhive-registry-server/pkg/config"
+	registryapp "github.com/stacklok/toolhive-registry-server/internal/app"
+	"github.com/stacklok/toolhive-registry-server/internal/config"
 )
 
 var serveCmd = &cobra.Command{

pkg/app/app.go renamed to internal/app/app.go

@@ -10,7 +10,7 @@ import (
 
 	"github.com/stacklok/toolhive/pkg/logger"
 
-	"github.com/stacklok/toolhive-registry-server/pkg/config"
+	"github.com/stacklok/toolhive-registry-server/internal/config"
 )
 
 // RegistryApp encapsulates all components needed to run the registry API server

pkg/app/builder.go renamed to internal/app/builder.go

@@ -13,12 +13,12 @@ import (
 	"github.com/stacklok/toolhive/pkg/logger"
 
 	"github.com/stacklok/toolhive-registry-server/internal/api"
+	"github.com/stacklok/toolhive-registry-server/internal/config"
 	"github.com/stacklok/toolhive-registry-server/internal/service"
-	"github.com/stacklok/toolhive-registry-server/pkg/config"
-	"github.com/stacklok/toolhive-registry-server/pkg/sources"
-	"github.com/stacklok/toolhive-registry-server/pkg/status"
-	pkgsync "github.com/stacklok/toolhive-registry-server/pkg/sync"
-	"github.com/stacklok/toolhive-registry-server/pkg/sync/coordinator"
+	sources2 "github.com/stacklok/toolhive-registry-server/internal/sources"
+	"github.com/stacklok/toolhive-registry-server/internal/status"
+	pkgsync "github.com/stacklok/toolhive-registry-server/internal/sync"
+	"github.com/stacklok/toolhive-registry-server/internal/sync/coordinator"
 )
 
 const (
@@ -41,8 +41,8 @@ type registryAppConfig struct {
 	config *config.Config
 
 	// Optional component overrides (primarily for testing)
-	sourceHandlerFactory sources.SourceHandlerFactory
-	storageManager       sources.StorageManager
+	sourceHandlerFactory sources2.SourceHandlerFactory
+	storageManager       sources2.StorageManager
 	statusPersistence    status.StatusPersistence
 	syncManager          pkgsync.Manager
 	registryProvider     service.RegistryDataProvider
@@ -184,15 +184,15 @@ func WithDataDirectory(dir string) RegistryAppOptions {
 }
 
 // WithSourceHandlerFactory allows injecting a custom source handler factory (for testing)
-func WithSourceHandlerFactory(factory sources.SourceHandlerFactory) RegistryAppOptions {
+func WithSourceHandlerFactory(factory sources2.SourceHandlerFactory) RegistryAppOptions {
 	return func(cfg *registryAppConfig) error {
 		cfg.sourceHandlerFactory = factory
 		return nil
 	}
 }
 
 // WithStorageManager allows injecting a custom storage manager (for testing)
-func WithStorageManager(sm sources.StorageManager) RegistryAppOptions {
+func WithStorageManager(sm sources2.StorageManager) RegistryAppOptions {
 	return func(cfg *registryAppConfig) error {
 		cfg.storageManager = sm
 		return nil
@@ -239,7 +239,7 @@ func buildSyncComponents(
 
 	// Build source handler factory
 	if b.sourceHandlerFactory == nil {
-		b.sourceHandlerFactory = sources.NewSourceHandlerFactory()
+		b.sourceHandlerFactory = sources2.NewSourceHandlerFactory()
 	}
 
 	// Build storage manager
@@ -248,7 +248,7 @@ func buildSyncComponents(
 		if err := os.MkdirAll(b.dataDir, 0750); err != nil {
 			return nil, fmt.Errorf("failed to create data directory %s: %w", b.dataDir, err)
 		}
-		b.storageManager = sources.NewFileStorageManager(b.dataDir)
+		b.storageManager = sources2.NewFileStorageManager(b.dataDir)
 	}
 
 	// Build status persistence

pkg/app/builder_test.go renamed to internal/app/builder_test.go

@@ -11,13 +11,13 @@ import (
 	"github.com/stretchr/testify/require"
 	"go.uber.org/mock/gomock"
 
+	"github.com/stacklok/toolhive-registry-server/internal/config"
 	"github.com/stacklok/toolhive-registry-server/internal/service"
 	"github.com/stacklok/toolhive-registry-server/internal/service/mocks"
-	"github.com/stacklok/toolhive-registry-server/pkg/config"
-	"github.com/stacklok/toolhive-registry-server/pkg/sources"
-	"github.com/stacklok/toolhive-registry-server/pkg/status"
-	pkgsync "github.com/stacklok/toolhive-registry-server/pkg/sync"
-	"github.com/stacklok/toolhive-registry-server/pkg/sync/coordinator"
+	"github.com/stacklok/toolhive-registry-server/internal/sources"
+	"github.com/stacklok/toolhive-registry-server/internal/status"
+	pkgsync "github.com/stacklok/toolhive-registry-server/internal/sync"
+	"github.com/stacklok/toolhive-registry-server/internal/sync/coordinator"
 )
 
 func TestNewRegistryAppBuilder(t *testing.T) {

pkg/app/components.go renamed to internal/app/components.go

@@ -2,7 +2,7 @@ package app
 
 import (
 	"github.com/stacklok/toolhive-registry-server/internal/service"
-	"github.com/stacklok/toolhive-registry-server/pkg/sync/coordinator"
+	"github.com/stacklok/toolhive-registry-server/internal/sync/coordinator"
 )
 
 // AppComponents groups all application components

pkg/config/config.go renamed to internal/config/config.go

@@ -8,7 +8,7 @@ import (
 	"github.com/stacklok/toolhive/pkg/registry"
 	"sigs.k8s.io/controller-runtime/pkg/log"
 
-	"github.com/stacklok/toolhive-registry-server/pkg/config"
+	"github.com/stacklok/toolhive-registry-server/internal/config"
 )
 
 // FilterService coordinates name and tag filtering to apply registry filters