Add tests for withoutOverlapping and before- and afterCallbacks

Author: marickvantuil

composer.json

@@ -16,7 +16,8 @@
     "require-dev": {
         "mockery/mockery": "^1.2",
         "orchestra/testbench": "^3.5 || ^3.6 || ^3.7 || ^3.8 || ^4.0 || ^5.0",
-        "symfony/console": "^4.4|^5.0"
+        "symfony/console": "^4.4|^5.0",
+        "timacdonald/log-fake": "^1.6"
     },
     "autoload": {
         "psr-4": {

tests/Support/Kernel.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace Tests\Support;
+
+use Illuminate\Console\Scheduling\Schedule;
+use Illuminate\Foundation\Console\Kernel as ConsoleKernel;
+
+class Kernel extends ConsoleKernel
+{
+    protected $commands = [
+        TestCommand::class,
+        TestCommand2::class,
+    ];
+
+    protected function schedule(Schedule $schedule)
+    {
+        $schedule->command('test:command')->withoutOverlapping();
+        $schedule->command('test:command2')->before(function () {
+            logger()->info('log after');
+        })->after(function () {
+            logger()->warning('log before');
+        });
+    }
+}

tests/Support/TestCommand.php

@@ -6,35 +6,9 @@
 
 class TestCommand extends Command
 {
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
     protected $signature = 'test:command';
-
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
     protected $description = 'Do some testy stuff';
 
-    /**
-     * Create a new command instance.
-     *
-     * @return void
-     */
-    public function __construct()
-    {
-        parent::__construct();
-    }
-
-    /**
-     * Execute the console command.
-     *
-     * @return mixed
-     */
     public function handle()
     {
         logger('did something testy');

tests/Support/TestCommand2.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace Tests\Support;
+
+use Illuminate\Console\Command;
+
+class TestCommand2 extends Command
+{
+    protected $signature = 'test:command2';
+
+    protected $description = 'Do some testy stuff';
+
+    public function handle()
+    {
+        logger('did something testy');
+    }
+}

tests/TaskHandlerTest.php

@@ -3,6 +3,7 @@
 namespace Tests;
 
 use Firebase\JWT\JWT;
+use Illuminate\Console\Application as ConsoleApplication;
 use Illuminate\Console\Scheduling\Schedule;
 use Illuminate\Container\Container;
 use Illuminate\Contracts\Console\Kernel;
@@ -13,6 +14,7 @@
 use Stackkit\LaravelGoogleCloudScheduler\OpenIdVerificator;
 use Stackkit\LaravelGoogleCloudScheduler\TaskHandler;
 use Throwable;
+use TiMacDonald\Log\LogFake;
 
 class TaskHandlerTest extends TestCase
 {
@@ -136,4 +138,46 @@ public function the_aud_claim_must_be_the_same_as_the_app_id()
 
         $this->taskHandler->handle();
     }
+
+    /** @test */
+    public function it_prevents_overlapping_if_the_command_is_scheduled_without_overlapping()
+    {
+        $this->fakeCommand->shouldReceive('capture')->andReturn('test:command');
+        $this->openId->shouldReceive('guardAgainstInvalidOpenIdToken')->andReturnNull();
+        $this->openId->shouldReceive('decodeToken')->andReturnNull();
+
+        cache()->clear();
+
+        Log::shouldReceive('debug')->twice();
+
+        $this->taskHandler->handle();
+
+        $expression = '* * * * *';
+        $command = ConsoleApplication::formatCommandString('test:command');
+        $mutex = 'framework'.DIRECTORY_SEPARATOR.'schedule-'.sha1($expression.$command);
+
+        cache()->add($mutex, true);
+
+        $this->taskHandler->handle();
+
+        cache()->delete($mutex);
+
+        $this->taskHandler->handle();
+    }
+
+    /** @test */
+    public function it_runs_the_before_and_after_callbacks()
+    {
+        $this->fakeCommand->shouldReceive('capture')->andReturn('test:command2');
+        $this->openId->shouldReceive('guardAgainstInvalidOpenIdToken')->andReturnNull();
+        $this->openId->shouldReceive('decodeToken')->andReturnNull();
+
+        Log::swap(new LogFake());
+
+        $this->taskHandler->handle();
+
+        Log::assertLoggedMessage('info', 'log after');
+        Log::assertLoggedMessage('warning', 'log before');
+        Log::assertLoggedMessage('debug', 'did something testy');
+    }
 }

tests/TestCase.php

@@ -2,6 +2,10 @@
 
 namespace Tests;
 
+use Illuminate\Console\Scheduling\Schedule;
+use Tests\Support\Kernel;
+use Tests\Support\TestCommand;
+
 class TestCase extends \Orchestra\Testbench\TestCase
 {
     /**
@@ -29,6 +33,9 @@ protected function getPackageProviders($app)
      */
     protected function getEnvironmentSetUp($app)
     {
-        //
+        $app->singleton(
+            \Illuminate\Contracts\Console\Kernel::class,
+            Kernel::class
+        );
     }
 }