Skip to content

Commit d9facbc

Browse files
committed
chore(logs): make acl desired type in model (like in logme syslog)
1 parent b719c76 commit d9facbc

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

internal/cmd/logs/instance/create/create.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ type inputModel struct {
3737

3838
DisplayName *string
3939
RetentionDays *int32
40-
ACL *[]string
40+
ACL []string
4141
Description *string
4242
}
4343

@@ -135,7 +135,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
135135
DisplayName: flags.FlagToStringPointer(p, cmd, displayNameFlag),
136136
RetentionDays: flags.FlagToInt32Pointer(p, cmd, retentionDaysFlag),
137137
Description: flags.FlagToStringPointer(p, cmd, descriptionFlag),
138-
ACL: flags.FlagToStringSlicePointer(p, cmd, aclFlag),
138+
ACL: flags.FlagToStringSliceValue(p, cmd, aclFlag),
139139
}
140140

141141
p.DebugInputModel(model)
@@ -148,7 +148,7 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *logs.APICli
148148
DisplayName: utils.PtrString(model.DisplayName),
149149
Description: model.Description,
150150
RetentionDays: utils.PtrValue(model.RetentionDays),
151-
Acl: utils.GetSliceFromPointer(model.ACL),
151+
Acl: model.ACL,
152152
})
153153
return req
154154
}

internal/cmd/logs/instance/create/create_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
6262
DisplayName: utils.Ptr(testDisplayName),
6363
Description: utils.Ptr(testDescription),
6464
RetentionDays: utils.Ptr(int32(testRetentionDays)),
65-
ACL: utils.Ptr([]string{testAcl}),
65+
ACL: []string{testAcl},
6666
}
6767
for _, mod := range mods {
6868
mod(model)

0 commit comments

Comments
 (0)