Improve colour thresholds for certificate expiry #1994
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing thresholds were: - expiry in more than 300 days: green - expiry between 140 and 300 days: yellow - expiry in less than 140 days: red These large values mean that Let's Encrypt certificates are always displayed in red because they are currently valid for 90 days. Adjust thresholds to be more useful: - expiry in more than 30 days: green - expiry between 7 and 30 days: yellow - expiry in less than 7 days: red
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the color thresholds for certificate expiry in the Grafana home dashboard. The new thresholds are more practical, especially for services using Let's Encrypt certificates, and the change correctly implements the logic described. I have one suggestion to improve the maintainability of the threshold values by using Jinja2 expressions to make them self-documenting.
Alex-Welsh
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing thresholds were:
These large values mean that Let's Encrypt certificates are always displayed in red because they are currently valid for 90 days.
Adjust thresholds to be more useful: