always delete resources on deploy failure in CI

Author: sjpb

.github/workflows/stackhpc.yml

@@ -66,24 +66,13 @@ jobs:
           cd $APPLIANCES_ENVIRONMENT_ROOT/terraform
           terraform apply -auto-approve
 
-      - name: Get server provisioning failure messages
-        id: provision_failure
-        run: |
-          . venv/bin/activate
-          . environments/.stackhpc/activate
-          cd $APPLIANCES_ENVIRONMENT_ROOT/terraform
-          TF_FAIL_MSGS="$(../../skeleton/\{\{cookiecutter.environment\}\}/terraform/getfaults.py  $PWD)"
-          echo TF failure messages: $TF_FAIL_MSGS
-          echo "::set-output name=messages::${TF_FAIL_MSGS}"
-        if: always() && steps.provision_servers.outcome == 'failure'
-        
       - name: Delete infrastructure if failed due to lack of hosts
         run: |
           . venv/bin/activate
           . environments/.stackhpc/activate
           cd $APPLIANCES_ENVIRONMENT_ROOT/terraform
           terraform destroy -auto-approve
-        if: ${{ always() && steps.provision_servers.outcome == 'failure' && contains(steps.provision_failure.messages, 'not enough hosts available') }}
+        if: ${{ steps.provision_servers.outcome == 'failure' }}
 
       - name: Configure cluster
         run: |