From 12804d0ffa87a2713d79eb9b123689d3dae75417 Mon Sep 17 00:00:00 2001 From: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com> Date: Tue, 4 Nov 2025 16:28:58 +0100 Subject: [PATCH 1/3] tests: pass on --listener-class-preset to stackablectl --- template/scripts/run-tests | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/template/scripts/run-tests b/template/scripts/run-tests index 44f27fca..046927cc 100755 --- a/template/scripts/run-tests +++ b/template/scripts/run-tests @@ -144,6 +144,14 @@ def parse_args(argv: list[str]) -> argparse.Namespace: default=os.path.join("tests", "_work"), ) + parser.add_argument( + "--listener-class-preset", + help="Choose the ListenerClass preset", + type=str, + required=False, + default="none", + ) + return parser.parse_args(argv) @@ -285,7 +293,7 @@ def release_file( logging.error(f"Failed to delete patched release file: {release_file}") -def maybe_install_release(skip_release: bool, release_file: str) -> None: +def maybe_install_release(skip_release: bool, release_file: str, listener_class_preset: str) -> None: if skip_release: logging.debug("Skip release installation") return @@ -296,6 +304,8 @@ def maybe_install_release(skip_release: bool, release_file: str) -> None: "install", "--release-file", release_file, + "--listener-class-preset", + listener_class_preset, "tests", ] logging.debug(f"Running : {stackablectl_cmd}") @@ -436,7 +446,7 @@ def main(argv) -> int: have_requirements() gen_tests(opts.test_suite, opts.namespace, opts.work_dir) with release_file(opts.operator, opts.skip_operator) as f: - maybe_install_release(opts.skip_release, f) + maybe_install_release(opts.skip_release, f, opts.listener_class_preset) if opts.skip_tests: logging.info("Skip running tests.") else: From 10a423d80ad04ed90b04c809c4e14a7f5ffaf2f7 Mon Sep 17 00:00:00 2001 From: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com> Date: Tue, 4 Nov 2025 16:53:28 +0100 Subject: [PATCH 2/3] make argument optional --- template/scripts/run-tests | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/template/scripts/run-tests b/template/scripts/run-tests index 046927cc..054b80a1 100755 --- a/template/scripts/run-tests +++ b/template/scripts/run-tests @@ -149,7 +149,6 @@ def parse_args(argv: list[str]) -> argparse.Namespace: help="Choose the ListenerClass preset", type=str, required=False, - default="none", ) return parser.parse_args(argv) @@ -304,8 +303,7 @@ def maybe_install_release(skip_release: bool, release_file: str, listener_class_ "install", "--release-file", release_file, - "--listener-class-preset", - listener_class_preset, + *(["--listener-class-preset", listener_class_preset] if listener_class_preset else []), "tests", ] logging.debug(f"Running : {stackablectl_cmd}") From 0aa7ec53885d09edb7f4152c07e983642dcda3d4 Mon Sep 17 00:00:00 2001 From: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com> Date: Tue, 4 Nov 2025 17:09:23 +0100 Subject: [PATCH 3/3] fix format lint --- template/scripts/run-tests | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/template/scripts/run-tests b/template/scripts/run-tests index 054b80a1..00639f45 100755 --- a/template/scripts/run-tests +++ b/template/scripts/run-tests @@ -292,7 +292,9 @@ def release_file( logging.error(f"Failed to delete patched release file: {release_file}") -def maybe_install_release(skip_release: bool, release_file: str, listener_class_preset: str) -> None: +def maybe_install_release( + skip_release: bool, release_file: str, listener_class_preset: str +) -> None: if skip_release: logging.debug("Skip release installation") return @@ -303,7 +305,11 @@ def maybe_install_release(skip_release: bool, release_file: str, listener_class_ "install", "--release-file", release_file, - *(["--listener-class-preset", listener_class_preset] if listener_class_preset else []), + *( + ["--listener-class-preset", listener_class_preset] + if listener_class_preset + else [] + ), "tests", ] logging.debug(f"Running : {stackablectl_cmd}")