Fix more pr comment and coroutine bug

Author: wenli-cai

workflow-trace-viewer/src/jvmMain/kotlin/com/squareup/workflow1/traceviewer/ui/TraceModeToggleSwitch.kt

@@ -6,10 +6,6 @@ import androidx.compose.material.Switch
 import androidx.compose.material.SwitchDefaults
 import androidx.compose.material.Text
 import androidx.compose.runtime.Composable
-import androidx.compose.runtime.getValue
-import androidx.compose.runtime.mutableStateOf
-import androidx.compose.runtime.remember
-import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
@@ -24,19 +20,13 @@ internal fun TraceModeToggleSwitch(
   traceMode: TraceMode,
   modifier: Modifier = Modifier
 ) {
-  // File mode is unchecked by default, and live mode is checked.
-  var checked by remember {
-    mutableStateOf(traceMode is TraceMode.Live)
-  }
-
   Column(
     modifier = modifier.padding(16.dp),
     horizontalAlignment = Alignment.CenterHorizontally
   ) {
     Switch(
-      checked = checked,
+      checked = traceMode is TraceMode.Live,
       onCheckedChange = {
-        checked = it
         onToggle()
       },
       colors = SwitchDefaults.colors(

workflow-trace-viewer/src/jvmMain/kotlin/com/squareup/workflow1/traceviewer/util/SocketClient.kt

@@ -1,6 +1,5 @@
 package com.squareup.workflow1.traceviewer.util
 
-import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.awaitCancellation
 import kotlinx.coroutines.channels.Channel
@@ -15,16 +14,18 @@ import java.net.Socket
 internal suspend fun streamRenderPassesFromDevice(parseOnNewRenderPass: (String) -> Unit) {
   val renderPassChannel: Channel<String> = Channel(Channel.BUFFERED)
   coroutineScope {
-    try {
-      pollSocket(onNewRenderPass = renderPassChannel::send)
-    } finally {
-      renderPassChannel.close()
+    launch {
+      try {
+        pollSocket(onNewRenderPass = renderPassChannel::send)
+      } finally {
+        renderPassChannel.close()
+      }
     }
-  }
 
-  // Since channel implements ChannelIterator, we can for-loop through on the receiver end.
-  for (renderPass in renderPassChannel) {
-    parseOnNewRenderPass(renderPass)
+    // Since channel implements ChannelIterator, we can for-loop through on the receiver end.
+    for (renderPass in renderPassChannel) {
+      parseOnNewRenderPass(renderPass)
+    }
   }
 }
 

workflow-trace-viewer/src/jvmMain/kotlin/com/squareup/workflow1/traceviewer/util/TraceParser.kt

@@ -90,7 +90,7 @@ internal fun RenderTrace(
   }
 
   if (error != null) {
-    Text("Error parsing: ${error}")
+    Text("Error parsing: $error")
     return
   }