Skip to content

patching chardet.universaldetector.MINIMUM_THRESHOLD #6024

@stanislavlevin

Description

@stanislavlevin

Patching of chardet.universaldetector.MINIMUM_THRESHOLD has been added in:
2f5a5e5#diff-8a51311f10a4c83f2aeafd6e2421c73dc4119c961d1c1f1fab7192c6e6f98aaeR59

In that version of bundled chardet the MINIMUM_THRESHOLD was the module level variable of chardet.universaldetector:

MINIMUM_THRESHOLD = 0.20

Later with updated chardet the MINIMUM_THRESHOLD has been moved:
bacf188#diff-bd2ab5211bb7e6b450f2c5eb45b93fe7f4475f9c5058b52d756dfacc4bc43677L38

but the patch reference was not updated.

chardet 7.0 dropped chardet.universaldetector module completely.

Is the patching of MINIMUM_THRESHOLD still needed? Looks like it does nothing atm.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions