Testing database sequence issues in tests fixed

Author: gionatamettifogo

test/compare.test.ts

@@ -111,8 +111,6 @@ describe('Database.on', () => {
 
 describe('Database.run', () => {
   it('sqlite3: insert with plain sql', done => {
-    const testingFile = createTestDatabaseFile()
-
     // https://github.com/TryGhost/node-sqlite3/wiki/API#runsql--param---callback
     function onInsert(error: Error, results: any) {
       expect(error).toBeNull()
@@ -127,12 +125,11 @@ describe('Database.run', () => {
       done()
     }
 
+    const testingFile = createTestDatabaseFile()
     testingFile.run(INSERT_SQL, onInsert)
   })
 
   it('sqlitecloud: insert with plain sql', done => {
-    const testingCloud = getTestingDatabase()
-
     // https://github.com/TryGhost/node-sqlite3/wiki/API#runsql--param---callback
     function onInsert(error: Error, results: any) {
       expect(error).toBeNull()
@@ -150,8 +147,10 @@ describe('Database.run', () => {
       testingCloud.close()
       done()
     }
-
-    testingCloud.run(INSERT_SQL, onInsert)
+    const testingCloud = getTestingDatabase(error => {
+      expect(error).toBeNull()
+      testingCloud.run(INSERT_SQL, onInsert)
+    })
   })
 
   // end run

test/database.test.ts

@@ -5,6 +5,7 @@
 import { SQLiteCloudRowset, SQLiteCloudRow, SQLiteCloudError } from '../src/index'
 import { getTestingDatabase, getTestingDatabaseAsync, getChinookDatabase, removeDatabase, removeDatabaseAsync, LONG_TIMEOUT } from './shared'
 import { RowCountCallback } from '../src/drivers/types'
+import e from 'express'
 
 //
 // utility methods to setup and destroy temporary test databases
@@ -37,8 +38,10 @@ describe('Database.run', () => {
         })
       }
 
-      const database = getTestingDatabase()
-      database.run(updateSql, plainCallbackNotALambda)
+      const database = getTestingDatabase(error => {
+        expect(error).toBeNull()
+        database.run(updateSql, plainCallbackNotALambda)
+      })
     },
     LONG_TIMEOUT
   )
@@ -84,8 +87,10 @@ describe('Database.run', () => {
         })
       }
 
-      const database = getTestingDatabase()
-      database.run(insertSql, plainCallbackNotALambdaOne)
+      const database = getTestingDatabase(error => {
+        expect(error).toBeNull()
+        database.run(insertSql, plainCallbackNotALambdaOne)
+      })
     },
     LONG_TIMEOUT
   )

test/shared.ts

@@ -13,6 +13,7 @@ import { SQLiteCloudWebsocketConnection } from '../src/drivers/connection-ws'
 
 import * as dotenv from 'dotenv'
 import { SQLiteCloudConnection, SQLiteCloudRowset } from '../src'
+import e from 'express'
 dotenv.config()
 
 export const LONG_TIMEOUT = 1 * 60 * 1000 // 1 minute
@@ -24,7 +25,7 @@ export const WARN_SPEED_MS = 500
 export const EXPECT_SPEED_MS = 6 * 1000
 
 /** Number of times or size of stress (when repeated in sequence) */
-export const SEQUENCE_TEST_SIZE = 75
+export const SEQUENCE_TEST_SIZE = 150
 /** Concurrency size for multiple connection tests */
 export const SIMULTANEOUS_TEST_SIZE = 150
 
@@ -160,9 +161,23 @@ export function getTestingConfig(url = TESTING_DATABASE_URL): SQLiteCloudConfig
 
 export function getTestingDatabase(callback?: ResultsCallback): Database {
   const testingConfig = getTestingConfig()
-  const database = new Database(testingConfig)
+  const database = new Database(testingConfig, error => {
+    if (error) {
+      console.error(`getTestingDatabase - connection error: ${error}`)
+      callback?.call(database, error)
+    }
+    database.run(TESTING_SQL, (error: SQLiteCloudError, results: SQLiteCloudRowset) => {
+      if (error) {
+        console.error(`getTestingDatabase - setup error: ${error}`)
+        callback?.call(database, error)
+      }
+      expect(results).toBeDefined()
+      expect(results[0][42]).toBe(42)
+      callback?.call(database, null)
+    })
+  })
+
   // database.verbose()
-  database.exec(TESTING_SQL, callback)
   return database
 }