From c87877f0f45e8df6cf94c36eef58926b80fc3aef Mon Sep 17 00:00:00 2001 From: Marco Bambini Date: Mon, 16 Nov 2026 09:41:54 +0100 Subject: [PATCH] fix: let the website changelog workflow fire on the tags this repo makes changelog.yml triggered on tags matching "v*.*.*", but the release job of main.yml tags with the bare version it reads from SQLITE_JS_VERSION: the tags on this repository are 1.4.0, 1.4.1, 1.4.2, 1.4.3, none with a v. So the pattern never matched a tag push and the workflow has run exactly once in its life, by hand on 2026-07-21, which is why no release since has reached the website changelog. It now uses "*.*.*", the pattern flutter-package.yml has always had, and that one does fire on these tags. The glob also matches a tag that does carry a v, so the workflow still runs if the tagging ever changes. This only opens the changelog pull request against the website's staging branch -- create_release stays false -- so firing on the real tag duplicates nothing main.yml already does. The 1.4.3 tag is already pushed, so this takes effect from the next release. 1.4.3 itself would need the workflow_dispatch, whose input is described as a fake version for testing. Co-Authored-By: Claude Opus 5 --- .github/workflows/changelog.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index 1ab9458..100bd92 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -2,8 +2,11 @@ name: Release and Update Website Changelog on: push: + # The release job of main.yml tags with the bare version from SQLITE_JS_VERSION, 1.4.3 and not + # v1.4.3, so a "v*.*.*" pattern here never matched and this workflow only ever ran by hand. + # Same pattern as flutter-package.yml, which has always had it right. tags: - - "v*.*.*" + - "*.*.*" workflow_dispatch: inputs: test_version: