Skip to content

Commit 022ba73

Browse files
committed
Added design notes
1 parent 8f0cab2 commit 022ba73

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Using regular links
2+
3+
:calendar: **Last edited on Feb 5, 2023**
4+
5+
You may have noticed that Visualizer uses regular `<a>` tags for navigation instead of React's `<Link>` components.
6+
7+
The reason is the following exception that's thrown when you follow a link to render another dataset:
8+
9+
![Error with React Router links](./files/error_with_router_links.png)
88.4 KB
Loading

src/Visualizer/components/DatabaseMenuPopup.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export function DatabaseMenuPopup(props: DatabaseMenuPopupProps) {
2626
<div key={databaseName}>
2727
<h3
2828
className="info-popup__database-name">
29+
{ /* design_notes/0001_using_regular_links.md */}
2930
<a href={`/databases/${databaseName}`}>{databases[databaseName].name}</a>
3031
</h3>
3132

0 commit comments

Comments
 (0)