Build with tsc instead of tsup (#842)

As reported in
#836 (comment),
my previous changes from #670 broke the ability for this package to be
tree-shaken.

This PR takes the other approach I had proposed in #604: it runs `tsc`
twice, once to produce a CJS build and once to produce an ESM one. It
writes a `package.json` file containing `{"type": "commonjs"}` to
`dist/cjs/package.json` so that the files in that directory are treated
as CJS.

Since #670 introduced an `exports` field, the internal changes to paths
shouldn't be visible to consumers, so this should be safe to release as
a patch or minor version. That said, I wouldn't blame you if you wanted
to release this as a major version to play it safe.

Author: nene

bin/sql-formatter-cli.cjs

@@ -2,7 +2,7 @@
 
 'use strict';
 
-const { format, supportedDialects } = require('../dist/index.cjs');
+const { format, supportedDialects } = require('../dist/cjs/index.js');
 const fs = require('fs');
 const path = require('path');
 const tty = require('tty');

package.json

@@ -3,14 +3,14 @@
   "version": "15.4.11",
   "description": "Format whitespace in a SQL query to make it more readable",
   "license": "MIT",
-  "main": "dist/index.cjs",
-  "module": "dist/index.js",
+  "main": "dist/cjs/index.cjs",
+  "module": "dist/esm/index.js",
   "unpkg": "dist/sql-formatter.min.js",
   "exports": {
     "./package.json": "./package.json",
     ".": {
-      "import": "./dist/index.js",
-      "require": "./dist/index.cjs"
+      "import": "./dist/esm/index.js",
+      "require": "./dist/cjs/index.cjs"
     }
   },
   "bin": {
@@ -63,9 +63,10 @@
     "prepare": "yarn clean && yarn grammar && yarn fix && yarn check && yarn build",
     "pre-commit": "npm-run-all --parallel ts:changes lint:changes",
     "grammar": "nearleyc src/parser/grammar.ne -o src/parser/grammar.ts",
-    "build:tsup": "tsup src/index.ts --format cjs,esm --sourcemap --dts",
+    "build:cjs": "tsc -p tsconfig.cjs.json && echo \"{\"type\": \"commonjs\"}\" > dist/cjs/package.json",
+    "build:esm": "tsc -p tsconfig.esm.json",
     "build:webpack": "webpack --config webpack.prod.js && cp dist/sql-formatter.min.cjs dist/sql-formatter.min.js",
-    "build": "yarn grammar && npm-run-all --parallel build:tsup build:webpack",
+    "build": "yarn grammar && npm-run-all --parallel build:cjs build:esm build:webpack",
     "release": "release-it"
   },
   "repository": {
@@ -111,7 +112,6 @@
     "rimraf": "^3.0.2",
     "ts-jest": "^28.0.5",
     "ts-loader": "^9.3.1",
-    "tsup": "^8.0.1",
     "typescript": "^4.7.4",
     "webpack": "^5.74.0",
     "webpack-cli": "^4.9.1",

tsconfig.cjs.json

@@ -0,0 +1,8 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "outDir": "dist/cjs",
+    "module": "CommonJS"
+  },
+  "include": ["src"]
+}

tsconfig.esm.json

@@ -0,0 +1,8 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "outDir": "dist/esm",
+    "module": "NodeNext"
+  },
+  "include": ["src"]
+}

tsconfig.json

@@ -1,17 +1,18 @@
 {
   "compilerOptions": {
     "module": "NodeNext",
+    "moduleResolution": "NodeNext",
     "target": "es6",
     "lib": ["es6", "dom"],
     "rootDirs": ["src"],
-    "outDir": "lib",
     "baseUrl": "./",
     "sourceMap": true,
     "declaration": true,
     "esModuleInterop": true,
-    "strict": true /* enable all strict type-checking options */,
-    /* Additional Checks */
-    "noImplicitReturns": true /* Report error when not all code paths in function return a value. */
+    // Enable all strict type-checking options.
+    "strict": true,
+    // Report error when not all code paths in function return a value.
+    "noImplicitReturns": true
   },
   "include": ["src", "test", "static"],
   "exclude": ["node_modules"]

webpack.common.js

@@ -20,7 +20,18 @@ export default {
       {
         test: /\.ts$/u,
         exclude: /node_modules/u,
-        use: ['babel-loader', 'ts-loader'],
+        use: [
+          'babel-loader',
+          {
+            loader: 'ts-loader',
+            options: {
+              // Prevent `ts-loader` from emitting types to the `lib` directory.
+              // This also disables type-checking, which is already performed
+              // independently of the webpack build process.
+              transpileOnly: true,
+            },
+          },
+        ],
       },
       {
         test: /\.js$/u,