Refactor and tidy #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Changes:** - Refactored and renamed many variables. - Added argument exceptions. - Changed formatting to PSR-2 standards. - Switched uppercase booleans to lowercase. - Added comments. - Added option for spaces with indent length instead of just tabs.
Added code examples to comments.
lcherone
commented
Dec 24, 2017
format.php
Outdated
| * $format = new Format(); | ||
| * | ||
| * // use spaces at 4 length | ||
| * echo $format->process('Unformatted HTML string'); |
Author
There was a problem hiding this comment.
whoops, this needs changing to $format->html(), same with others but doesn't affect functionality.
Author
|
fixes booboo's with comments and readme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2 + plus many other changes and tidy.