Better option parsing for phpenv-install

Author: sptndc

bin/phpenv-install

@@ -11,23 +11,54 @@ if [ -z "$PHPENV_ROOT" ]; then
   PHPENV_ROOT="${HOME}/.phpenv"
 fi
 
-DEFINITION="$1"
-case "$DEFINITION" in
-"" | -* )
-  { echo "usage: phpenv install VERSION"
-    echo "       phpenv install /path/to/definition"
+# Load shared library functions
+eval "$(php-build --lib)" && lib
+
+usage() {
+  { echo "usage: phpenv install [-k|--keep] [-v|--verbose] VERSION"
+    echo "       phpenv install [-k|--keep] [-v|--verbose] /path/to/definition"
+    echo "       phpenv install -l|--list"
     echo
-    echo "Available versions:"
-    php-build --definitions | sed 's/^/  /'
+    echo "  -l/--list        List all available versions"
+    echo "  -k/--keep        Keep source tree in \$PHPENV_BUILD_ROOT after installation"
+    echo "                   (defaults to ${PHPENV_ROOT}/sources)"
+    echo "  -v/--verbose     Verbose mode: print compilation status to stdout"
     echo
   } >&2
-  exit 1
-  ;;
-"-k" | "--keep" )
-  [ -z "${PHPENV_BUILD_ROOT}" ] && PHPENV_BUILD_ROOT="${PHPENV_ROOT}/sources"
-  PHP_BUILD_OPTIONS="${PHP_BUILD_OPTIONS} -k"
-  ;;
-esac
+  [ -z "$1" ] || exit "$1"
+}
+
+unset KEEP
+unset VERBOSE
+
+parse_options "$@"
+for option in "${OPTIONS[@]}"; do
+  case "$option" in
+  "h" | "help" )
+    usage 0
+    ;;
+  "l" | "list" )
+    echo "Available versions:"
+    php-build --definitions | sed 's/^/  /'
+    exit
+    ;;
+  "k" | "keep" )
+    [ -n "${PHPENV_BUILD_ROOT}" ] || PHPENV_BUILD_ROOT="${PHPENV_ROOT}/sources"
+    ;;
+  "v" | "verbose" )
+    VERBOSE="-v"
+    ;;
+  "version" )
+    exec php-build --version
+    ;;
+  * )
+    usage 1
+    ;;
+  esac
+done
+
+DEFINITION="${ARGUMENTS[0]}"
+[ -n "$DEFINITION" ] || usage 1
 
 VERSION_NAME="${DEFINITION##*/}"
 PREFIX="${PHPENV_ROOT}/versions/${VERSION_NAME}"
@@ -36,8 +67,8 @@ PREFIX="${PHPENV_ROOT}/versions/${VERSION_NAME}"
 # php-build
 if [ -n "${PHPENV_BUILD_ROOT}" ]; then
   export PHP_BUILD_BUILD_PATH="${PHPENV_BUILD_ROOT}/${VERSION_NAME}"
-  PHP_BUILD_OPTIONS="${PHP_BUILD_OPTIONS} -k"
+  KEEP="-k"
 fi
 
-php-build "$DEFINITION" "$PREFIX" "$PHP_BUILD_OPTIONS"
+php-build $KEEP $VERBOSE "$DEFINITION" "$PREFIX"
 phpenv rehash