project review

Author: bnasslahsen

build.gradle.kts

@@ -34,7 +34,7 @@ dependencies {
     implementation(group = "khttp", name = "khttp", version = "1.0.0")
     implementation(group = "com.google.code.gson", name = "gson", version = "2.8.6")
     implementation(group = "org.awaitility", name = "awaitility-kotlin", version = "4.0.2")
-    implementation(files("/home/ramesh/gradle-processes/build/libs/gradle-processes-0.5.0.jar"))
+    implementation(group = "gradle.plugin.com.github.jengelman.gradle.plugins", name = "gradle-processes", version = "0.5.0")
 }
 
 gradlePlugin {

src/main/kotlin/org/springdoc/openapi/gradle/plugin/OpenApiGeneratorTask.kt

@@ -10,21 +10,23 @@ import org.gradle.api.DefaultTask
 import org.gradle.api.file.DirectoryProperty
 import org.gradle.api.provider.Property
 import org.gradle.api.tasks.Input
+import org.gradle.api.tasks.Nested
 import org.gradle.api.tasks.OutputDirectory
 import org.gradle.api.tasks.TaskAction
 import java.net.ConnectException
 import java.time.Duration
 import java.time.temporal.ChronoUnit.SECONDS
 
 
-open class OpenApiGeneratorTask: DefaultTask() {
+open class OpenApiGeneratorTask : DefaultTask() {
     @get:Input
     val apiDocsUrl: Property<String> = project.objects.property(String::class.java)
     @get:Input
     val outputFileName: Property<String> = project.objects.property(String::class.java)
     @get:OutputDirectory
     val outputDir: DirectoryProperty = project.objects.directoryProperty()
     private val waitTimeInSeconds: Property<Int> = project.objects.property(Int::class.java)
+    @get:Nested
     val taskError: Property<String> = project.objects.property(String::class.java)
 
     init {
@@ -49,7 +51,10 @@ open class OpenApiGeneratorTask: DefaultTask() {
     @TaskAction
     fun execute() {
         try {
-            await ignoreException ConnectException::class withPollInterval Durations.ONE_SECOND atMost Duration.of(waitTimeInSeconds.get().toLong(), SECONDS) until {
+            await ignoreException ConnectException::class withPollInterval Durations.ONE_SECOND atMost Duration.of(
+                waitTimeInSeconds.get().toLong(),
+                SECONDS
+            ) until {
                 val statusCode = khttp.get(apiDocsUrl.get()).statusCode
                 logger.trace("apiDocsUrl = {} status code = {}", apiDocsUrl.get(), statusCode)
                 statusCode < 299
@@ -63,7 +68,10 @@ open class OpenApiGeneratorTask: DefaultTask() {
             outputFile.writeText(gson.toJson(googleJsonObject))
         } catch (e: ConditionTimeoutException) {
             taskError.set("Timeout occurred while trying to connect to ${apiDocsUrl.get()}")
-            this.logger.error("Unable to connect to ${apiDocsUrl.get()} waited for ${waitTimeInSeconds.get()} seconds", e)
+            this.logger.error(
+                "Unable to connect to ${apiDocsUrl.get()} waited for ${waitTimeInSeconds.get()} seconds",
+                e
+            )
         }
     }