Commit 7199ea4
committed
Redesign command programming model
This commit revisits the previous programming model in order to fix
several design issues and inconsistencies. The major changes are:
- Revisit declarative and programmatic command definition
- Redesign command registration and discovery
- Introduce new adapters to create commands from annotated methods
- Fix incorrect implementation of non-interactive shells #1218
- Remove Shell runner precedence #1219
- Make interactive mode the default #1186
- Remove CommandResolver which is redundant #1217
- Make it easier to use Spring Shell without Spring Boot #1207
- Revisit exceptions
I tried to introduce these changes in an incremental way, but APIs
were so entangled together that it was very hard to break them down
to smaller change sets.
This commit does not address Spring Boot support on purpose.
Support for Spring Boot will be addressed in a separate commit.
Resolves #1186
Resolves #1207
Resolves #1217
Resolves #1218
Resolves #12191 parent 1f65aec commit 7199ea4
File tree
117 files changed
+1103
-13477
lines changed- spring-shell-core/src
- main/java/org/springframework/shell/core
- commands
- adapter
- command
- annotation
- support
- invocation
- parser
- support
- completion
- context
- jline
- result
- test/java/org/springframework/shell/core
- commands
- command
- annotation
- support
- invocation
- parser
- completion
- jline
- result
- spring-shell-samples
- spring-shell-sample-hello-world/src/main/java/org/springframework/shell/samples/helloworld
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
117 files changed
+1103
-13477
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
94 | 94 | | |
95 | | - | |
| 95 | + | |
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| |||
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | | - | |
| 43 | + | |
45 | 44 | | |
46 | | - | |
| 45 | + | |
47 | 46 | | |
48 | 47 | | |
49 | 48 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
32 | 34 | | |
33 | 35 | | |
34 | 36 | | |
| |||
0 commit comments