Add missing nullability annotations in AbstractConfiguredSecurityBuilder#19307
Open
therepanic wants to merge 1 commit into
Open
Add missing nullability annotations in AbstractConfiguredSecurityBuilder#19307therepanic wants to merge 1 commit into
AbstractConfiguredSecurityBuilder#19307therepanic wants to merge 1 commit into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Since the package containing `AbstractConfiguredSecurityBuilder` is annotated with `@NullMarked`, we should annotate the methods that return null with `@Nullable`. Closes: spring-projectsgh-19304 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
commented
Jun 9, 2026
Comment on lines
84
to
87
|
|
||
| var authenticationManager: AuthenticationManager? = null | ||
| val context: ApplicationContext = http.getSharedObject(ApplicationContext::class.java) | ||
| val context: ApplicationContext = http.getSharedObject(ApplicationContext::class.java)!! | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Without this, the build fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the package containing
AbstractConfiguredSecurityBuilderis annotated with@NullMarked, we should annotate the methods that return null with@Nullable.Closes: gh-19304