Add setPreAuthenticationChecks to Reactive Manager#19278
Open
big-cir wants to merge 1 commit into
Open
Conversation
The pre-authentication checks could not be customized, unlike the post-authentication checks and the servlet counterpart. Closes spring-projectsgh-19275 Signed-off-by: dae won <eodnjs01477@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
AbstractUserDetailsReactiveAuthenticationManagerruns pre-authentication checks (locked/disabled/expired) before validating the password, but unlike the post-authentication checks they cannot be customized:The servlet counterpart (
AbstractUserDetailsAuthenticationProvider) allows customizing both. This PR adds the missingsetPreAuthenticationCheckssetter (@since 7.1) along with tests for null validation and for a custom checker being invoked during authentication.Related Issue
Closes gh-19275