Skip to content

Commit 2709bc1

Browse files
artembilangaryrussell
authored andcommitted
Upgrade to the latest Kotlin
* Fix more recursive generics on factory methods See https://jira.spring.io/browse/INT-4458 **Cherry-pick to 5.0.x**
1 parent 5cbc622 commit 2709bc1

File tree

4 files changed

+21
-15
lines changed

4 files changed

+21
-15
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
buildscript {
2-
ext.kotlinVersion = '1.2.41'
2+
ext.kotlinVersion = '1.2.51'
33
repositories {
44
maven { url 'https://repo.spring.io/plugins-release' }
55
}

spring-integration-core/src/main/java/org/springframework/integration/dsl/Channels.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,20 +104,19 @@ public RendezvousChannelSpec rendezvous(String id) {
104104
return MessageChannels.rendezvous(id);
105105
}
106106

107-
public PublishSubscribeChannelSpec<? extends PublishSubscribeChannelSpec<?>> publishSubscribe() {
107+
public PublishSubscribeChannelSpec<?> publishSubscribe() {
108108
return MessageChannels.publishSubscribe();
109109
}
110110

111-
public PublishSubscribeChannelSpec<? extends PublishSubscribeChannelSpec<?>> publishSubscribe(Executor executor) {
111+
public PublishSubscribeChannelSpec<?> publishSubscribe(Executor executor) {
112112
return MessageChannels.publishSubscribe(executor);
113113
}
114114

115-
public PublishSubscribeChannelSpec<? extends PublishSubscribeChannelSpec<?>> publishSubscribe(String id,
116-
Executor executor) {
115+
public PublishSubscribeChannelSpec<?> publishSubscribe(String id, Executor executor) {
117116
return MessageChannels.publishSubscribe(id, executor);
118117
}
119118

120-
public PublishSubscribeChannelSpec<? extends PublishSubscribeChannelSpec<?>> publishSubscribe(String id) {
119+
public PublishSubscribeChannelSpec<?> publishSubscribe(String id) {
121120
return MessageChannels.publishSubscribe(id);
122121
}
123122

spring-integration-core/src/main/java/org/springframework/integration/dsl/channel/MessageChannels.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ public static QueueChannelSpec.MessageStoreSpec queue(ChannelMessageStore messag
6969

7070
public static QueueChannelSpec.MessageStoreSpec queue(String id, ChannelMessageStore messageGroupStore,
7171
Object groupId) {
72+
7273
return queue(messageGroupStore, groupId).id(id);
7374
}
7475

@@ -102,26 +103,24 @@ public static PriorityChannelSpec priority(PriorityCapableChannelMessageStore me
102103

103104
public static PriorityChannelSpec priority(String id,
104105
PriorityCapableChannelMessageStore messageGroupStore, Object groupId) {
106+
105107
return priority(messageGroupStore, groupId).id(id);
106108
}
107109

108-
public static <S extends PublishSubscribeChannelSpec<S>> PublishSubscribeChannelSpec<S> publishSubscribe() {
110+
public static PublishSubscribeChannelSpec<?> publishSubscribe() {
109111
return new PublishSubscribeChannelSpec<>();
110112
}
111113

112-
public static <S extends PublishSubscribeChannelSpec<S>> PublishSubscribeChannelSpec<S> publishSubscribe(
113-
String id) {
114-
return MessageChannels.<S>publishSubscribe().id(id);
114+
public static PublishSubscribeChannelSpec<?> publishSubscribe(String id) {
115+
return MessageChannels.publishSubscribe().id(id);
115116
}
116117

117-
public static <S extends PublishSubscribeChannelSpec<S>> PublishSubscribeChannelSpec<S> publishSubscribe(
118-
Executor executor) {
118+
public static PublishSubscribeChannelSpec<?> publishSubscribe(Executor executor) {
119119
return new PublishSubscribeChannelSpec<>(executor);
120120
}
121121

122-
public static <S extends PublishSubscribeChannelSpec<S>> PublishSubscribeChannelSpec<S> publishSubscribe(String id,
123-
Executor executor) {
124-
return MessageChannels.<S>publishSubscribe(executor).id(id);
122+
public static PublishSubscribeChannelSpec<?> publishSubscribe(String id, Executor executor) {
123+
return MessageChannels.publishSubscribe(executor).id(id);
125124
}
126125

127126
public static FluxMessageChannelSpec flux() {

spring-integration-core/src/test/kotlin/org/springframework/integration/dsl/routers/RouterDslTests.kt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ import org.springframework.context.annotation.Bean
2727
import org.springframework.context.annotation.Configuration
2828
import org.springframework.integration.config.EnableIntegration
2929
import org.springframework.integration.dsl.IntegrationFlow
30+
import org.springframework.integration.dsl.channel.MessageChannels
31+
import org.springframework.integration.support.MessageBuilder
3032
import org.springframework.messaging.MessageChannel
3133
import org.springframework.messaging.PollableChannel
3234
import org.springframework.messaging.support.GenericMessage
@@ -83,6 +85,12 @@ class RouterDslTests {
8385
.channel { c -> c.queue("routerTwoSubFlowsOutput") }
8486
}
8587

88+
89+
@Bean
90+
fun publishSubscribe() =
91+
MessageChannels.publishSubscribe()
92+
.ignoreFailures(true)
93+
.applySequence(false)
8694
}
8795

8896
}

0 commit comments

Comments
 (0)