Add missing @Deprecated(forRemoval = true) for deleted in 7.0

[seregamorph]

There are a lot of classes/methods/constructors removed in 7.0 release. Many of these are missing @Deprecated(forRemoval=true) annotations (even just @Deprecated is missing) in the latest 6.2.17.
This may be critical as during migration you need to distinguish which deprecations are critical and which are not.
For a trivial microservice based on pure spring-boot this can be quite ok as it will simply lead to compilation failures highlighting all cases.
But for the huge codebases with hundreds of libraries this is quite challenging. For org.springframework.* libraries there is confidence (as we mostly take their versions from spring-boot-dependencies, others can be found on https://spring.io/projects/generations#mappings), but for own libraries based on spring as well as any third-party this can become an issue caught in the runtime.
E.g. within our organization we implemented arch-unit tests scanning project modules and all JAR dependencies on usages of classes/methods/constructors/fields marked as @Deprecated(forRemoval = true) to make the migration more safe.
The list of classes, methods, constructors and fields missing the proper annotation:
⚠️ these are replaced with updated lists in the comments (as original lists had false positives)

• missing-deprecated-forRemoval-classes.txt
• missing-deprecated-forRemoval-public-constructors.txt
• missing-deprecated-forRemoval-protected-constructors.txt
• missing-deprecated-forRemoval-methods-public.txt
• missing-deprecated-forRemoval-methods-protected.txt
• missing-deprecated-forRemoval-fields-public.txt

This discussion started within PR addressing some of these #36562 but with @bclozel we agreed to close the PR and create a separate issue.

[seregamorph]

@bclozel few notes:

• I've added all lists that I planned (see issue description)
• if the class is mentioned in the missing-deprecated-forRemoval-classes.txt, items from it are not listed for missing deprecations for constructors/methods/fields
• I've separated protected and public members to different files
• sorry if some of the lines are false positives (the list was so big, but the report was semi-automated so it's at least looks reasonable)

[bclozel]

Thanks for your work @seregamorph .
I have processed the missing-deprecated-forRemoval-classes.txt and I think there are a lot of false positives. To me, the only invalid case would be deleting a class that was not marked previously @Deprecated(since="...", forRemoval = true).

Is there a bug in your archunit check maybe? I can continue processing the files you provided, but removing the false positives would help a lot. Maybe your tool considers that a type should be first @Deprecated and then @Deprecated(forRemoval = true) as a second step? In my opinion, deprecating for removal in one step is a valid use of the annotation and communicates the removal intent directly.

False positives

Class	6.2.x	7.0.x
org.springframework.aot.agent.*	N/A	@Deprecated forRemoval
org.springframework.aot.hint.*	N/A	@Deprecated forRemoval
org.springframework.aot.hint.predicate.*	N/A	@Deprecated forRemoval
org.springframework.aot.test.agent.*	N/A	@Deprecated forRemoval
org.springframework.beans.factory.config.*	@Deprecated	@Deprecated forRemoval
org.springframework.beans.support.*	N/A	@Deprecated forRemoval
org.springframework.core.io.*	N/A	@Deprecated forRemoval
org.springframework.dao.support.*	N/A	@Deprecated forRemoval
org.springframework.http.converter.*	N/A	@Deprecated forRemoval
org.springframework.jdbc.core.*	N/A	@Deprecated forRemoval
org.springframework.jms.*	N/A	@Deprecated forRemoval
org.springframework.test.http.*	N/A	@Deprecated forRemoval
org.springframework.web.reactive.result.method.annotation.*	N/A	@Deprecated forRemoval
org.springframework.web.servlet.handler.*	N/A	@Deprecated forRemoval
org.springframework.web.servlet.mvc.condition.*	N/A	@Deprecated forRemoval
org.springframework.web.servlet.mvc.method.annotation.*	N/A	@Deprecated forRemoval
org.springframework.web.servlet.view.json.*	N/A	@Deprecated forRemoval
org.springframework.web.servlet.view.xml.*	N/A	@Deprecated forRemoval
org.springframework.web.socket.sockjs.frame.*	N/A	@Deprecated forRemoval

@Deprecated without forRemoval and removed

org.springframework.http.client.reactive.ReactorResourceFactory (package change)
org.springframework.ui.context.* (Theme related classes)
org.springframework.util.concurrent.MonoToListenableFutureAdapter
org.springframework.web.accept.PathExtensionContentNegotiationStrategy
org.springframework.web.accept.ServletPathExtensionContentNegotiationStrategy
org.springframework.web.reactive.function.client.ExchangeFilterFunctions$Credentials
org.springframework.web.servlet.ThemeResolver
org.springframework.web.servlet.mvc.LastModified
org.springframework.web.servlet.tags.ThemeTag
org.springframework.web.servlet.theme.AbstractThemeResolver
org.springframework.web.servlet.theme.CookieThemeResolver
org.springframework.web.servlet.theme.FixedThemeResolver
org.springframework.web.servlet.theme.SessionThemeResolver
org.springframework.web.servlet.theme.ThemeChangeInterceptor
org.springframework.web.servlet.view.ResourceBundleViewResolver
org.springframework.web.servlet.view.XmlViewResolver
org.springframework.web.util.CookieGenerator
org.springframework.web.util.NestedServletException

Removed with no prior warning:

org.springframework.core.codec.Netty5BufferDecoder
org.springframework.core.codec.Netty5BufferEncoder
org.springframework.core.io.buffer.Netty5DataBuffer
org.springframework.core.io.buffer.Netty5DataBufferFactory
org.springframework.http.client.reactive.ReactorNetty2ClientHttpConnector
org.springframework.http.client.reactive.ReactorNetty2ResourceFactory
org.springframework.http.server.reactive.JettyHttpHandlerAdapter [see 3b65506c13f18535e2fb055fd790bf45efb13de5]
org.springframework.http.server.reactive.ReactorNetty2HttpHandlerAdapter
org.springframework.http.server.reactive.UndertowHttpHandlerAdapter
org.springframework.http.support.Netty5HeadersAdapter
org.springframework.messaging.tcp.reactor.ReactorNetty2TcpClient
org.springframework.messaging.tcp.reactor.ReactorNetty2TcpConnection
org.springframework.web.reactive.socket.adapter.Netty5WebSocketSessionSupport
org.springframework.web.reactive.socket.adapter.ReactorNetty2WebSocketSession
org.springframework.web.reactive.socket.adapter.UndertowWebSocketHandlerAdapter
org.springframework.web.reactive.socket.adapter.UndertowWebSocketSession
org.springframework.web.reactive.socket.client.ReactorNetty2WebSocketClient
org.springframework.web.reactive.socket.client.UndertowWebSocketClient
org.springframework.web.reactive.socket.server.upgrade.ReactorNetty2RequestUpgradeStrategy (see gh-33744)
org.springframework.web.reactive.socket.server.upgrade.TomcatRequestUpgradeStrategy (see gh-33744)
org.springframework.web.reactive.socket.server.upgrade.UndertowRequestUpgradeStrategy (see gh-33744)
org.springframework.web.servlet.view.document.AbstractPdfStamperView
org.springframework.web.servlet.view.document.AbstractPdfView
org.springframework.web.servlet.view.document.AbstractXlsView
org.springframework.web.servlet.view.document.AbstractXlsxStreamingView
org.springframework.web.servlet.view.document.AbstractXlsxView
org.springframework.web.servlet.view.feed.AbstractAtomFeedView
org.springframework.web.servlet.view.feed.AbstractFeedView
org.springframework.web.servlet.view.feed.AbstractRssFeedView
rg.springframework.web.socket.server.standard.AbstractStandardUpgradeStrategy (see gh-33744)
org.springframework.web.socket.server.standard.AbstractTyrusRequestUpgradeStrategy (see gh-33744)
org.springframework.web.socket.server.standard.GlassFishRequestUpgradeStrategy (see gh-33744)
org.springframework.web.socket.server.standard.TomcatRequestUpgradeStrategy (see gh-33744)
org.springframework.web.socket.server.standard.UndertowRequestUpgradeStrategy (see gh-33744)
org.springframework.web.socket.server.standard.WebLogicRequestUpgradeStrategy (see gh-33744)
org.springframework.web.socket.server.standard.WebSphereRequestUpgradeStrategy (see gh-33744)
org.springframework.web.socket.sockjs.client.UndertowXhrTransport

Hibernate 5

The org.springframework.orm.hibernate5 package is a special case, see #35111. The change was called out in our documentation, but I'm wondering if @Deprecate-ing those types now would have any net benefit. What do you think @jhoeller ?

[seregamorph]

I see what was my mistake (if the class is marked for deletion in spring-framework 7, but still present), that's indeed false positives. Will re-calculate the lists.
Sorry

[seregamorph]

Updated list of classes which are missing @Deprecated or @Deprecated(forRemoval = true):

org.springframework.core.codec.Netty5BufferDecoder
org.springframework.core.codec.Netty5BufferEncoder
org.springframework.core.io.buffer.Netty5DataBuffer
org.springframework.core.io.buffer.Netty5DataBufferFactory
org.springframework.http.client.reactive.ReactorNetty2ClientHttpConnector
org.springframework.http.client.reactive.ReactorNetty2ResourceFactory
org.springframework.http.client.reactive.ReactorResourceFactory
org.springframework.http.server.reactive.JettyHttpHandlerAdapter
org.springframework.http.server.reactive.ReactorNetty2HttpHandlerAdapter
org.springframework.http.server.reactive.UndertowHttpHandlerAdapter
org.springframework.http.support.Netty5HeadersAdapter
org.springframework.messaging.tcp.reactor.ReactorNetty2TcpClient
org.springframework.messaging.tcp.reactor.ReactorNetty2TcpConnection
org.springframework.ui.context.HierarchicalThemeSource
org.springframework.ui.context.Theme
org.springframework.ui.context.ThemeSource
org.springframework.ui.context.support.DelegatingThemeSource
org.springframework.ui.context.support.ResourceBundleThemeSource
org.springframework.ui.context.support.SimpleTheme
org.springframework.ui.context.support.UiApplicationContextUtils
org.springframework.util.concurrent.MonoToListenableFutureAdapter
org.springframework.web.accept.PathExtensionContentNegotiationStrategy
org.springframework.web.accept.ServletPathExtensionContentNegotiationStrategy
org.springframework.web.reactive.function.client.ExchangeFilterFunctions$Credentials
org.springframework.web.reactive.server.ServerWebExchangeExtensionsKt
org.springframework.web.reactive.socket.adapter.Netty5WebSocketSessionSupport
org.springframework.web.reactive.socket.adapter.ReactorNetty2WebSocketSession
org.springframework.web.reactive.socket.adapter.ReactorNetty2WebSocketSession$WebSocketConnection
org.springframework.web.reactive.socket.adapter.UndertowWebSocketHandlerAdapter
org.springframework.web.reactive.socket.adapter.UndertowWebSocketSession
org.springframework.web.reactive.socket.client.ReactorNetty2WebSocketClient
org.springframework.web.reactive.socket.client.UndertowWebSocketClient
org.springframework.web.reactive.socket.server.upgrade.ReactorNetty2RequestUpgradeStrategy
org.springframework.web.reactive.socket.server.upgrade.TomcatRequestUpgradeStrategy
org.springframework.web.reactive.socket.server.upgrade.UndertowRequestUpgradeStrategy
org.springframework.web.servlet.ThemeResolver
org.springframework.web.servlet.mvc.LastModified
org.springframework.web.servlet.tags.ThemeTag
org.springframework.web.servlet.theme.AbstractThemeResolver
org.springframework.web.servlet.theme.CookieThemeResolver
org.springframework.web.servlet.theme.FixedThemeResolver
org.springframework.web.servlet.theme.SessionThemeResolver
org.springframework.web.servlet.theme.ThemeChangeInterceptor
org.springframework.web.servlet.view.ResourceBundleViewResolver
org.springframework.web.servlet.view.XmlViewResolver
org.springframework.web.socket.server.standard.AbstractStandardUpgradeStrategy
org.springframework.web.socket.server.standard.AbstractTyrusRequestUpgradeStrategy
org.springframework.web.socket.server.standard.GlassFishRequestUpgradeStrategy
org.springframework.web.socket.server.standard.TomcatRequestUpgradeStrategy
org.springframework.web.socket.server.standard.UndertowRequestUpgradeStrategy
org.springframework.web.socket.server.standard.WebLogicRequestUpgradeStrategy
org.springframework.web.socket.server.standard.WebSphereRequestUpgradeStrategy
org.springframework.web.socket.sockjs.client.UndertowXhrTransport
org.springframework.web.util.CookieGenerator
org.springframework.web.util.NestedServletException

I removed hibernate5 from this list. Also spring-jcl is not listed here (as it's not a valid case to mention it there). Note: as for now the lists of methods/constructors/fields are NOT yet updated

[seregamorph]

While re-calculating the list of missing deprecated annotations for methods, I've found one more interesting pitfall.
E.g. org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.isSingleton() looks like deleted, but actually it's now inherited via the super-interface default method :)

[bclozel]

Thanks for the update @seregamorph .

E.g. org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.isSingleton() looks like deleted, but actually it's now inherited via the super-interface default method :)

With major upgrades, we try to keep source compatibility as much as possible but we don't guarantee binary compatibility. We don't expect any application/library to be runtime compatible with both 6.2.x and 7.0.x.

I'm working on the updated list. Some of the reported types (like the Theme support) were deprecated in 6.0 but we didn't use the forRemoval flag back then. This means that since 6.0 developers need to suppress deprecation warnings to use these types. We are quite late in the 6.2.x line, so I don't think it's worth adding that removal flag now:

• developers who added @SuppressWarnings("deprecation") will see a new compilation error and will need to update those to @SuppressWarnings("removal")
• developers who are simply ignoring compilation warnings won't see any difference

We're now trying to consistently add forRemoval when we know the API will be removed in a future release. I guess that for those instances, it's not worth punishing developers during a maintenance upgrade. So I'll just go ahead and add @Deprecated on class/methods that were completely missing that information.

[bclozel]

Another note on the WebSocket *UpgradeStrategy. As noted in gh-33744, it's really the Jakarta baseline upgrade that makes those immediately outdated. @Deprecate-ing those in 6.2.x has no meaning since Framework users might have no other choice if they're not using Jakarta WebSocket 2.1 already. I won't be deprecating those as a result.

[seregamorph]

WDYT regarding marking these static consts that are removed in 7.0?:

org.springframework.http.HttpStatus.CHECKPOINT
org.springframework.http.HttpStatus.DESTINATION_LOCKED
org.springframework.http.HttpStatus.INSUFFICIENT_SPACE_ON_RESOURCE
org.springframework.http.HttpStatus.METHOD_FAILURE
org.springframework.http.HttpStatus.MOVED_TEMPORARILY
org.springframework.http.HttpStatus.REQUEST_ENTITY_TOO_LARGE
org.springframework.http.HttpStatus.REQUEST_URI_TOO_LONG
org.springframework.http.HttpStatus.USE_PROXY

org.springframework.http.MediaType.APPLICATION_JSON_UTF8
org.springframework.http.MediaType.APPLICATION_JSON_UTF8_VALUE
org.springframework.http.MediaType.APPLICATION_PROBLEM_JSON_UTF8
org.springframework.http.MediaType.APPLICATION_PROBLEM_JSON_UTF8_VALUE
org.springframework.http.MediaType.APPLICATION_STREAM_JSON
org.springframework.http.MediaType.APPLICATION_STREAM_JSON_VALUE

org.springframework.web.servlet.DispatcherServlet.THEME_RESOLVER_ATTRIBUTE
org.springframework.web.servlet.DispatcherServlet.THEME_RESOLVER_BEAN_NAME
org.springframework.web.servlet.DispatcherServlet.THEME_SOURCE_ATTRIBUTE
org.springframework.web.servlet.support.RequestContext.DEFAULT_THEME_NAME

[seregamorph]

List of constructors that seems to be missing @Deprecated(forRemoval = true):

org.springframework.http.client.reactive.JettyClientHttpConnector.<init>(org.springframework.http.client.reactive.JettyResourceFactory, java.util.function.Consumer)
org.springframework.http.converter.HttpMessageNotReadableException.<init>(java.lang.String)
org.springframework.http.converter.HttpMessageNotReadableException.<init>(java.lang.String, java.lang.Throwable)
org.springframework.http.server.reactive.AbstractServerHttpRequest.<init>(org.springframework.http.HttpMethod, java.net.URI, java.lang.String, org.springframework.util.MultiValueMap)
org.springframework.test.web.reactive.server.CookieAssertions.<init>(org.springframework.test.web.reactive.server.ExchangeResult, org.springframework.test.web.reactive.server.WebTestClient$ResponseSpec)
org.springframework.web.client.RestTemplate.<init>(java.util.List)
org.springframework.web.reactive.resource.NoResourceFoundException.<init>(java.lang.String)
org.springframework.web.reactive.result.method.RequestMappingInfo.<init>(java.lang.String, org.springframework.web.reactive.result.condition.PatternsRequestCondition, org.springframework.web.reactive.result.condition.RequestMethodsRequestCondition, org.springframework.web.reactive.result.condition.ParamsRequestCondition, org.springframework.web.reactive.result.condition.HeadersRequestCondition, org.springframework.web.reactive.result.condition.ConsumesRequestCondition, org.springframework.web.reactive.result.condition.ProducesRequestCondition, org.springframework.web.reactive.result.condition.RequestCondition)
org.springframework.web.reactive.result.method.RequestMappingInfo.<init>(org.springframework.web.reactive.result.condition.PatternsRequestCondition, org.springframework.web.reactive.result.condition.RequestMethodsRequestCondition, org.springframework.web.reactive.result.condition.ParamsRequestCondition, org.springframework.web.reactive.result.condition.HeadersRequestCondition, org.springframework.web.reactive.result.condition.ConsumesRequestCondition, org.springframework.web.reactive.result.condition.ProducesRequestCondition, org.springframework.web.reactive.result.condition.RequestCondition)
org.springframework.web.reactive.result.method.RequestMappingInfo.<init>(org.springframework.web.reactive.result.method.RequestMappingInfo, org.springframework.web.reactive.result.condition.RequestCondition)
org.springframework.web.reactive.socket.HandshakeInfo.<init>(java.net.URI, org.springframework.http.HttpHeaders, reactor.core.publisher.Mono, java.lang.String, java.net.InetSocketAddress, java.util.Map, java.lang.String)
org.springframework.web.service.invoker.HttpRequestValues$Builder.<init>()
org.springframework.web.service.invoker.ReactiveHttpRequestValues$Builder.<init>()
org.springframework.web.servlet.config.annotation.ContentNegotiationConfigurer.<init>(jakarta.servlet.ServletContext)
org.springframework.web.servlet.mvc.condition.PatternsRequestCondition.<init>([Ljava.lang.String;, boolean, org.springframework.util.PathMatcher)
org.springframework.web.servlet.mvc.condition.PatternsRequestCondition.<init>([Ljava.lang.String;, org.springframework.web.util.UrlPathHelper, org.springframework.util.PathMatcher, boolean)
org.springframework.web.servlet.mvc.condition.PatternsRequestCondition.<init>([Ljava.lang.String;, org.springframework.web.util.UrlPathHelper, org.springframework.util.PathMatcher, boolean, boolean)
org.springframework.web.servlet.mvc.condition.PatternsRequestCondition.<init>([Ljava.lang.String;, org.springframework.web.util.UrlPathHelper, org.springframework.util.PathMatcher, boolean, boolean, java.util.List)
org.springframework.web.servlet.mvc.method.RequestMappingInfo.<init>(java.lang.String, org.springframework.web.servlet.mvc.condition.PatternsRequestCondition, org.springframework.web.servlet.mvc.condition.RequestMethodsRequestCondition, org.springframework.web.servlet.mvc.condition.ParamsRequestCondition, org.springframework.web.servlet.mvc.condition.HeadersRequestCondition, org.springframework.web.servlet.mvc.condition.ConsumesRequestCondition, org.springframework.web.servlet.mvc.condition.ProducesRequestCondition, org.springframework.web.servlet.mvc.condition.RequestCondition)
org.springframework.web.servlet.mvc.method.RequestMappingInfo.<init>(org.springframework.web.servlet.mvc.condition.PatternsRequestCondition, org.springframework.web.servlet.mvc.condition.RequestMethodsRequestCondition, org.springframework.web.servlet.mvc.condition.ParamsRequestCondition, org.springframework.web.servlet.mvc.condition.HeadersRequestCondition, org.springframework.web.servlet.mvc.condition.ConsumesRequestCondition, org.springframework.web.servlet.mvc.condition.ProducesRequestCondition, org.springframework.web.servlet.mvc.condition.RequestCondition)
org.springframework.web.servlet.resource.NoResourceFoundException.<init>(org.springframework.http.HttpMethod, java.lang.String)
org.springframework.web.util.ContentCachingRequestWrapper.<init>(jakarta.servlet.http.HttpServletRequest)

Regarding methods this needs more complicated code analysis for reasons discussed before (consider inheritance), so I'll try to submit the updated list a bit later

[bclozel]

WDYT regarding marking these static consts that are removed in 7.0?:

org.springframework.http.HttpStatus.CHECKPOINT
org.springframework.http.HttpStatus.DESTINATION_LOCKED
org.springframework.http.HttpStatus.INSUFFICIENT_SPACE_ON_RESOURCE
org.springframework.http.HttpStatus.METHOD_FAILURE
org.springframework.http.HttpStatus.MOVED_TEMPORARILY
org.springframework.http.HttpStatus.REQUEST_ENTITY_TOO_LARGE
org.springframework.http.HttpStatus.REQUEST_URI_TOO_LONG
org.springframework.http.HttpStatus.USE_PROXY

org.springframework.http.MediaType.APPLICATION_JSON_UTF8
org.springframework.http.MediaType.APPLICATION_JSON_UTF8_VALUE
org.springframework.http.MediaType.APPLICATION_PROBLEM_JSON_UTF8
org.springframework.http.MediaType.APPLICATION_PROBLEM_JSON_UTF8_VALUE
org.springframework.http.MediaType.APPLICATION_STREAM_JSON
org.springframework.http.MediaType.APPLICATION_STREAM_JSON_VALUE

org.springframework.web.servlet.DispatcherServlet.THEME_RESOLVER_ATTRIBUTE
org.springframework.web.servlet.DispatcherServlet.THEME_RESOLVER_BEAN_NAME
org.springframework.web.servlet.DispatcherServlet.THEME_SOURCE_ATTRIBUTE
org.springframework.web.servlet.support.RequestContext.DEFAULT_THEME_NAME

I think all of those are already @Deprecated, admittedly without any since nor forRemoval information. Same reasoning: at this stage, adding forRemoval is just likely to annoy developers late in the 6.2.x generation since they already got the message.

---

List of constructors that seems to be missing @Deprecated(forRemoval = true):

org.springframework.http.client.reactive.JettyClientHttpConnector.<init>(org.springframework.http.client.reactive.JettyResourceFactory, java.util.function.Consumer)
org.springframework.http.converter.HttpMessageNotReadableException.<init>(java.lang.String)
org.springframework.http.converter.HttpMessageNotReadableException.<init>(java.lang.String, java.lang.Throwable)
org.springframework.web.reactive.result.method.RequestMappingInfo.<init>(java.lang.String, org.springframework.web.reactive.result.condition.PatternsRequestCondition, org.springframework.web.reactive.result.condition.RequestMethodsRequestCondition, org.springframework.web.reactive.result.condition.ParamsRequestCondition, org.springframework.web.reactive.result.condition.HeadersRequestCondition, org.springframework.web.reactive.result.condition.ConsumesRequestCondition, org.springframework.web.reactive.result.condition.ProducesRequestCondition, org.springframework.web.reactive.result.condition.RequestCondition)
org.springframework.web.reactive.result.method.RequestMappingInfo.<init>(org.springframework.web.reactive.result.condition.PatternsRequestCondition, org.springframework.web.reactive.result.condition.RequestMethodsRequestCondition, org.springframework.web.reactive.result.condition.ParamsRequestCondition, org.springframework.web.reactive.result.condition.HeadersRequestCondition, org.springframework.web.reactive.result.condition.ConsumesRequestCondition, org.springframework.web.reactive.result.condition.ProducesRequestCondition, org.springframework.web.reactive.result.condition.RequestCondition)
org.springframework.web.reactive.result.method.RequestMappingInfo.<init>(org.springframework.web.reactive.result.method.RequestMappingInfo, org.springframework.web.reactive.result.condition.RequestCondition)
org.springframework.web.reactive.socket.HandshakeInfo.<init>(java.net.URI, org.springframework.http.HttpHeaders, reactor.core.publisher.Mono, java.lang.String, java.net.InetSocketAddress, java.util.Map, java.lang.String)
org.springframework.web.servlet.mvc.condition.PatternsRequestCondition.<init>([Ljava.lang.String;, boolean, org.springframework.util.PathMatcher)
org.springframework.web.servlet.mvc.condition.PatternsRequestCondition.<init>([Ljava.lang.String;, org.springframework.web.util.UrlPathHelper, org.springframework.util.PathMatcher, boolean)
org.springframework.web.servlet.mvc.condition.PatternsRequestCondition.<init>([Ljava.lang.String;, org.springframework.web.util.UrlPathHelper, org.springframework.util.PathMatcher, boolean, boolean)
org.springframework.web.servlet.mvc.condition.PatternsRequestCondition.<init>([Ljava.lang.String;, org.springframework.web.util.UrlPathHelper, org.springframework.util.PathMatcher, boolean, boolean, java.util.List)
org.springframework.web.servlet.mvc.method.RequestMappingInfo.<init>(java.lang.String, org.springframework.web.servlet.mvc.condition.PatternsRequestCondition, org.springframework.web.servlet.mvc.condition.RequestMethodsRequestCondition, org.springframework.web.servlet.mvc.condition.ParamsRequestCondition, org.springframework.web.servlet.mvc.condition.HeadersRequestCondition, org.springframework.web.servlet.mvc.condition.ConsumesRequestCondition, org.springframework.web.servlet.mvc.condition.ProducesRequestCondition, org.springframework.web.servlet.mvc.condition.RequestCondition)
org.springframework.web.servlet.mvc.method.RequestMappingInfo.<init>(org.springframework.web.servlet.mvc.condition.PatternsRequestCondition, org.springframework.web.servlet.mvc.condition.RequestMethodsRequestCondition, org.springframework.web.servlet.mvc.condition.ParamsRequestCondition, org.springframework.web.servlet.mvc.condition.HeadersRequestCondition, org.springframework.web.servlet.mvc.condition.ConsumesRequestCondition, org.springframework.web.servlet.mvc.condition.ProducesRequestCondition, org.springframework.web.servlet.mvc.condition.RequestCondition)

Those already had the @Deprecated annotation, so same reasoning.

---

org.springframework.http.server.reactive.AbstractServerHttpRequest.<init>(org.springframework.http.HttpMethod, java.net.URI, java.lang.String, org.springframework.util.MultiValueMap)
org.springframework.web.reactive.resource.NoResourceFoundException.<init>(java.lang.String)
org.springframework.web.servlet.resource.NoResourceFoundException.<init>(org.springframework.http.HttpMethod, java.lang.String)

Those could be deprecated, but they have no replacement we can point developers to. Typically unfortunate breaking changes that we couldn't avoid or methods that we think are not likely to be used by the community.

---

org.springframework.test.web.reactive.server.CookieAssertions.<init>(org.springframework.test.web.reactive.server.ExchangeResult, org.springframework.test.web.reactive.server.WebTestClient$ResponseSpec)
org.springframework.web.service.invoker.HttpRequestValues$Builder.<init>()
org.springframework.web.service.invoker.ReactiveHttpRequestValues$Builder.<init>()
org.springframework.web.servlet.config.annotation.ContentNegotiationConfigurer.<init>(jakarta.servlet.ServletContext)

I think the constructors were never meant to be public and there is no use for public instantiation of those types.

---

org.springframework.web.client.RestTemplate.<init>(java.util.List)

Was replaced by public RestTemplate(Iterable<HttpMessageConverter<?>> messageConverters), a source compatible change.

---

org.springframework.web.util.ContentCachingRequestWrapper.<init>(jakarta.servlet.http.HttpServletRequest)

This one is indeed missing, I think it was missed during #33914 I'll fix that here.

[bclozel]

Regarding methods this needs more complicated code analysis for reasons discussed before (consider inheritance), so I'll try to submit the updated list a bit later

Thanks for your efforts here @seregamorph - maybe don't spend a lot of time on this. I guess you encountered concrete cases while upgrading and we'd rather target those as a priority.