Fix RootUriTemplateHandler to apply rootUri for empty URI templates #48364
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
- Updated RootUriTemplateHandler.apply() to: - Prefix rootUri if uriTemplate starts with '/' - Return rootUri if uriTemplate is blank - This ensures correct behavior for empty and relative paths Signed-off-by: Hyunwoo Gu <realization0327@gmail.com>
- Added tests for RootUriTemplateHandler.apply() covering: - URIs starting with '/' - Empty string - Blank string - Absolute URLs - Relative paths - Ensures apply() behaves as expected in all edge cases Signed-off-by: Hyunwoo Gu <realization0327@gmail.com>
…oreEach Annotation Signed-off-by: Hyunwoo Gu <realization0327@gmail.com>
Member
|
Thanks for the PR @guhyunwoo, but given the #48337 (comment) I'm going to leave things as they are until the next minor release of Spring Boot. |
philwebb
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #48337
Fix bug in RootUriTemplateHandler where rootUri was not applied for empty URI templates (""). Previously, apply() only prefixed rootUri for paths starting with /.
Update apply() to return rootUri when the URI template is empty, ensuring consistent behavior with RestTemplateBuilder.rootUri() in @HttpExchange methods.
Add unit test uriStringWhenEmptyShouldReturnRoot() in RootUriBuilderFactoryTests to verify this behavior.
These changes ensure that both empty and non-empty URI templates are handled correctly.