Skip to content

Feature Request: Redis sentinel password support #268

@xinxinran0221010

Description

@xinxinran0221010

I am encountering an issue when I am trying to use split-synchronizer, which uses go-split-common library.

In my environment, Redis is deployed as cluster mode and sentinel mode is enabled with sentinel password.

When I passed the Redis settings to split-synchronizer, I got "Unauthenticated" error from Redis. After troubleshooting, I found it caused by incorrect sentinel password.

Currently go-split-common doesn't support sentinel password, while the dependency package splitio/go-toolkit supports this setting (https://github.com/splitio/go-toolkit/blob/main/redis/types.go#L25).

So could you please try to add this SentinelPassword parameter support?

As my investigation, just adding two lines in 2 files respectively is enough:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions