@@ -19,6 +19,7 @@ import (
1919 "github.com/splitio/go-split-commons/v9/storage/mocks"
2020 "github.com/splitio/go-split-commons/v9/telemetry"
2121 "github.com/splitio/go-toolkit/v5/logging"
22+ "github.com/stretchr/testify/assert"
2223)
2324
2425func TestImpressionRecorderError (t * testing.T ) {
@@ -63,7 +64,7 @@ func TestImpressionRecorderWithoutImpressions(t *testing.T) {
6364
6465func TestSynhronizeEventErrorRecorder (t * testing.T ) {
6566 impression := dtos.Impression {
66- BucketingKey : "someBucketingKey1" , ChangeNumber : 123456789 , FeatureName : "someFeature1" ,
67+ BucketingKey : "someBucketingKey1" , ChangeNumber : 123456789 , FeatureName : "someFeature1" , Properties : "{'prop':'val'}" ,
6768 KeyName : "someKey1" , Label : "someLabel" , Time : 123456789 , Treatment : "someTreatment1" ,
6869 }
6970
@@ -104,7 +105,7 @@ func TestImpressionRecorder(t *testing.T) {
104105 before := time .Now ().UTC ()
105106 impression1 := dtos.Impression {
106107 BucketingKey : "someBucketingKey1" , ChangeNumber : 123456789 , FeatureName : "someFeature1" ,
107- KeyName : "someKey1" , Label : "someLabel" , Time : 123456789 , Treatment : "someTreatment1" ,
108+ KeyName : "someKey1" , Label : "someLabel" , Time : 123456789 , Treatment : "someTreatment1" , Properties : "{'prop':'val'}" ,
108109 }
109110 impression2 := dtos.Impression {
110111 BucketingKey : "someBucketingKey2" , ChangeNumber : 123456789 , FeatureName : "someFeature2" ,
@@ -215,6 +216,7 @@ func TestImpressionRecorderSync(t *testing.T) {
215216 if ! ok || len (imp1 .KeyImpressions ) != 2 {
216217 t .Error ("Incorrect impressions received" )
217218 }
219+ assert .Equal (t , "{'prop':'val'}" , imp1 .KeyImpressions [0 ].Properties )
218220 imp2 , ok := result ["someFeature2" ]
219221 if ! ok || len (imp2 .KeyImpressions ) != 1 {
220222 t .Error ("Incorrect impressions received" )
@@ -227,7 +229,7 @@ func TestImpressionRecorderSync(t *testing.T) {
227229
228230 impression1 := dtos.Impression {
229231 BucketingKey : "someBucketingKey1" , ChangeNumber : 123456789 , FeatureName : "someFeature1" ,
230- KeyName : "someKey1" , Label : "someLabel" , Time : 123456789 , Treatment : "someTreatment1" ,
232+ KeyName : "someKey1" , Label : "someLabel" , Time : 123456789 , Treatment : "someTreatment1" , Properties : "{'prop':'val'}" ,
231233 }
232234 impression2 := dtos.Impression {
233235 BucketingKey : "someBucketingKey2" , ChangeNumber : 123456789 , FeatureName : "someFeature2" ,
0 commit comments