-
Notifications
You must be signed in to change notification settings - Fork 42
Feat(preferences): Create a UI for collection preferences #7557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CarolineDenis
wants to merge
63
commits into
main
Choose a base branch
from
issue-7553
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggered by c490308 on branch refs/heads/issue-7553
CarolineDenis
commented
Nov 21, 2025
| <cell colspan="3" id="20" label="RESTORE_EXPANSION_STATE" name="TreeEditor.RestoreTreeExpansionState" type="field" uitype="checkbox" /> | ||
| </row> | ||
| <row> | ||
| <cell colspan="3" id="-20" label="PROMPT_TO_REPLACE_SYNONYM" name="Determination.PromptToReplaceSynonym" type="field" uitype="checkbox" /> |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go through this file and remove obsolete cells
CarolineDenis
commented
Nov 21, 2025
| @@ -0,0 +1,78 @@ | |||
| import type { RA } from '../../utils/types'; | |||
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
necessary? See permissions/definitions.ts
For the changes in #6721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7553
Checklist
self-explanatory (or properly documented)
Testing instructions
TaxonTreeEditor.DisplayAuthor
Sorting in trees
Test rank threshold:
Go to User Preferences
Verify that under each tree there is an option to configure the "Show object count"'
Verify that the ranks returned are correct for the current collection's tree(s)
Select a rank from each tree
Verify that the counts for all nodes under that level are shown in the tree
Test this across all current trees and verify the behavior
sp7_scope_table_picklists
attachment.is_public_default
sp7.allow_adding_child_to_synonymized_parent.{table}
showPreparationsTotal
catalogNumberParentInheritance.inheritance
uniqueCatalogNumberAccrossComponentAndCO
For those 2, verify the feature is still working. Refer to step 4 and 12 in the testing instructions of #6721
catalogNumberInheritance.inheritance
Security