Removing unnecessary 'memcpy'

PaulZC · PaulZC · commit baf36c782426 · 2020-12-10T14:57:58.000Z
diff --git a/src/SFE_MicroOLED.cpp b/src/SFE_MicroOLED.cpp
@@ -458,12 +458,7 @@ void MicroOLED::display(void)
 		setColumnAddress(0);
 		if (interface == MODE_I2C)
 		{
-			uint8_t store[0x40];
-			for (j = 0; j < 0x40; j++)
-			{
-				store[j] = screenmemory[i * 0x40 + j];
-			}
-			i2cWriteMultiple(i2c_address, (uint8_t *)&store, 0x40);
+			i2cWriteMultiple(i2c_address, (uint8_t *)&screenmemory[i * 0x40], 0x40);
 		}
 		else
 		{
diff --git a/src/hardware.cpp b/src/hardware.cpp
@@ -100,7 +100,7 @@ void MicroOLED::i2cWrite(byte address, byte dc, byte data)
 /** \brief  Write multiple data bytes over I2C
 
 	Write multiple bytes to I2C device _address_.
-	Returns true if all numDataBytes were pushed successfully
+	Returns true if all numDataBytes were written successfully
 **/
 boolean MicroOLED::i2cWriteMultiple(uint8_t address, uint8_t *dataBytes, size_t numDataBytes)
 {

Original file line number	Diff line number	Diff line change
`@@ -458,12 +458,7 @@ void MicroOLED::display(void)`
`458`	`458`	`setColumnAddress(0);`
`459`	`459`	`if (interface == MODE_I2C)`
`460`	`460`	`{`
`461`		`- uint8_t store[0x40];`
`462`		`- for (j = 0; j < 0x40; j++)`
`463`		`- {`
`464`		`- store[j] = screenmemory[i * 0x40 + j];`
`465`		`- }`
`466`		`- i2cWriteMultiple(i2c_address, (uint8_t *)&store, 0x40);`
	`461`	`+ i2cWriteMultiple(i2c_address, (uint8_t )&screenmemory[i 0x40], 0x40);`
`467`	`462`	`}`
`468`	`463`	`else`
`469`	`464`	`{`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ void MicroOLED::i2cWrite(byte address, byte dc, byte data)`
`100`	`100`	`/** \brief Write multiple data bytes over I2C`
`101`	`101`
`102`	`102`	`Write multiple bytes to I2C device _address_.`
`103`		`- Returns true if all numDataBytes were pushed successfully`
	`103`	`+ Returns true if all numDataBytes were written successfully`
`104`	`104`	`**/`
`105`	`105`	`boolean MicroOLED::i2cWriteMultiple(uint8_t address, uint8_t *dataBytes, size_t numDataBytes)`
`106`	`106`	`{`