Enable bugprone-unchecked-optional-access clang-tidy check

[bavulapati]

@jviotti We are currently using assert before consuming std::optional's value.
The assert won't be present in production builds.
How should we handle this case? What to do in the case where optional doesn't have value?

[jviotti]

Unless there is a case I missed and escaped the tests (could be?), I only assert when I'm sure that the optional is set because of some other pre-conditions, etc

[bavulapati]

@jviotti PTAL

[jviotti]

Hey @bavulapati , I'm not sure that are you still working on these, so let me close them to reduce noise. Always feel free to re-open if you ever get back to it