sonarqube:9.0.0-community branch list api doesn't return commit info (#9)

simonwu-sn · web-flow · commit 8ef1f37e525f · 2021-07-20T11:26:00.000-07:00
* Update sonarqube.ts
* revise per comment
diff --git a/src/api.ts b/src/api.ts
@@ -113,7 +113,7 @@ export interface Branch {
         codeSmells?: number
     }
     analysisDate: string
-    commit: {
+    commit?: {
         sha: string
         author: {
             name: string
diff --git a/src/sonarqube.ts b/src/sonarqube.ts
@@ -104,7 +104,7 @@ export function activate(context: sourcegraph.ExtensionContext): void {
                         }
 
                         const branches = await listBranches({ project, ...apiOptions })
-                        const branch = branches.find(branch => branch.commit.sha === commitID)
+                        const branch = branches.find(branch => branch?.commit?.sha === commitID)
                         if (!branch) {
                             console.warn(
                                 `No Sonarqube branch found for commit ID ${commitID}, falling back to default branch`

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ export function activate(context: sourcegraph.ExtensionContext): void {`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`const branches = await listBranches({ project, ...apiOptions })`
`107`		`- const branch = branches.find(branch => branch.commit.sha === commitID)`
	`107`	`+ const branch = branches.find(branch => branch?.commit?.sha === commitID)`
`108`	`108`	`if (!branch) {`
`109`	`109`	`console.warn(`
`110`	`110`	`No Sonarqube branch found for commit ID ${commitID}, falling back to default branch`