Skip to content

2.0.0-beta.4: Failed to execute 'appendChild' on 'Node' #2650

@clinuxrulz

Description

@clinuxrulz

Describe the bug

Rendering a DOM element stored in a reactive store crashes with "Failed to execute 'appendChild' on 'Node'" in Solid 2.0.0-beta.4, but works correctly in Solid 1.9.12.

Your Example Website or App

https://clinuxrulz.github.io/solid-2-playground/#s=UEsDBAoAAAAIAIAAfVw7j/xpHAEAANMBAAAIAAAAbWFpbi50c3hVkE1PAjEURffzKy5ddZIRcCvDRI0mmOgKEhfGBdI3pqTTkvYNYnD+u50PBHdN3nnvnl5d7ZxnHLHxtGZasvOEBqV3FURwRqurbRCzRJ84T1aR/0NuO2YbJl/0EbGEDh2nqFzXhlHWdsPaWdztdjLFMQEMMd4QOKZlCMTL9oV3zC8V8pYElN7fYLF6eX7Q+0dDFVnGD+poUGpLKotQU8gL9v8ojUJoM1a6IlezjArzAj3fesSdmKvcpm5Pj3uBIUiKOBXxxHB8rK0lv6IDxxWxIGMcXp03aiR65vQXKUMfgzAeAvR+1tlEpwzX0+m0N/PEtbeQeXHs+mjxJp8UcdokSd/04JzHAjEpsrPsJ/Fgev/9pKTwzrFIR+nsF1BLAwQKAAAACACAAH1c6FDxomYAAACnAAAADwAAAGltcG9ydC1tYXAuanNvbqvmUlBQyswtyC8qKVayUqgGcoECxfk5mSm6WSARpYySkoJiK3391OJcveIMfZiUg5GegZ6BblJqSaKeiX1KapmSDkSvA1hFVrF+eWoSFv3I0hhmqKVWlKQW5SXm2MJdADS0lqsWAFBLAQIUAAoAAAAIAIAAfVw7j/xpHAEAANMBAAAIAAAAAAAAAAAAAAAAAAAAAABtYWluLnRzeFBLAQIUAAoAAAAIAIAAfVzoUPGiZgAAAKcAAAAPAAAAAAAAAAAAAAAAAEIBAABpbXBvcnQtbWFwLmpzb25QSwUGAAAAAAIAAgBzAAAA1QEAAAAA

Steps to Reproduce the Bug or Issue

import { createStore } from "solid-js";
import { render } from "@solidjs/web";

export default function App() {
  let [ state, setState ] = createStore<{
    div: HTMLDivElement | undefined,
  }>({
    div: undefined,
  });

  setTimeout(() => {
    let div = document.createElement("div");
    div.innerText = "Hello World!";
    setState((s) => { s.div = div; });
  }, 1000);

  return (<>{state.div}</>);
}

render(() => <App />, document.getElementById("root")!);

Expected behavior

The DOM element should render without errors, as it does in Solid 1.9.12.

Actual behavior

Uncaught TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.

Screenshots or Videos

No response

Platform

  • OS: Ubuntu
  • Solid-js version: 2.0.0-beta.4
  • Browser: Chrome (latest)

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions