Fix intermittent tab titles on overview pages (#1390)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: KipZonderKop101 <80620930+KipzonderKop101@users.noreply.github.com>
Co-authored-by: Amir Hossein Hashemi <87268103+amirhhashemi@users.noreply.github.com>

Author: 5 people

scripts/collections/build-file-tree.mjs

@@ -44,7 +44,8 @@ export async function buildFileTree(entry = COLLECTIONS_ROOT) {
 			const file = await fs.readFile(entryPath, "utf-8");
 			const parentSection = await getDirData(path.resolve(parentSegment));
 
-			const { title, mainNavExclude, isDeprecated } = matter(file).data;
+			const { title, nav_title, mainNavExclude, isDeprecated } =
+				matter(file).data;
 
 			/**
 			 * @todo
@@ -61,7 +62,7 @@ export async function buildFileTree(entry = COLLECTIONS_ROOT) {
 						.replace(/\.mdx?/, ""),
 				slug: path.basename(entryPath, path.extname(entryPath)),
 				parent: parentSection.title,
-				title,
+				title: nav_title ?? title,
 				mainNavExclude,
 				isDeprecated,
 				isTranslated: true,

scripts/create-i18n-entries.mjs

@@ -40,14 +40,14 @@ async function buildSectionList(entryList = [], locale, project = "") {
 		);
 
 		if (existsSync(i18nEntryPath + ".mdx")) {
-			const { title, isDeprecated } = await getFrontMatterData(
+			const { title, nav_title, isDeprecated } = await getFrontMatterData(
 				i18nEntryPath + ".mdx"
 			);
 
 			sectionList.push({
 				...entry,
 				path: path.join(locale, entry.path),
-				title,
+				title: nav_title ?? title,
 				isDeprecated,
 				isTranslated: true,
 			});

src/routes/index.mdx

@@ -1,5 +1,7 @@
 ---
-title: Overview
+title: Solid Docs
+nav_title: Overview
+titleTemplate: ":title"
 mainNavExclude: true
 use_cases: >-
   getting started, learning solid, understanding framework, first project,

src/routes/solid-meta/index.mdx

@@ -1,5 +1,7 @@
 ---
-title: Overview
+title: Solid Meta Docs
+nav_title: Overview
+titleTemplate: ":title"
 mainNavExclude: true
 use_cases: >-
   managing head tags, seo optimization, document metadata, dynamic meta tags,

src/routes/solid-router/concepts/data.json

@@ -8,7 +8,6 @@
 		"nesting.mdx",
 		"layouts.mdx",
 		"alternative-routers.mdx",
-		"queries.mdx",
 		"actions.mdx"
 	]
 }

src/routes/solid-router/index.mdx

@@ -1,5 +1,7 @@
 ---
-title: Overview
+title: Solid Router Docs
+nav_title: Overview
+titleTemplate: ":title"
 use_cases: >-
   understanding routing, learning basics, overview needed, getting started, spa
   routing concepts

src/routes/solid-router/reference/primitives/use-match.mdx

@@ -148,5 +148,5 @@ function FileInfo() {
 
 ## Related
 
-- [`useParams`](/reference/primitives/use-params)
-- [`useLocation`](/reference/primitives/use-location)
+- [`useParams`](/solid-router/reference/primitives/use-params)
+- [`useLocation`](/solid-router/reference/primitives/use-location)

src/routes/solid-start/index.mdx

@@ -1,5 +1,7 @@
 ---
-title: Overview
+title: SolidStart Docs
+nav_title: Overview
+titleTemplate: ":title"
 use_cases: >-
   getting started, new projects, learning solidstart, framework overview,
   architecture decisions

src/solidbase-theme/Layout.tsx

@@ -6,17 +6,13 @@ import { NotFound } from "~/ui/not-found";
 import { I18nProvider } from "~/i18n/i18n-context";
 import { useThemeListener } from "@kobalte/solidbase/client";
 import { usePace } from "@kobalte/solidbase/default-theme/pace.js";
-import { Title } from "@solidjs/meta";
-import { useProjectTitle } from "~/ui/use-project";
 
 export default function (props: RouteSectionProps) {
 	useThemeListener();
 	usePace();
-	const projectTitle = useProjectTitle();
 
 	return (
 		<I18nProvider>
-			<Title>{projectTitle()}</Title>
 			<ErrorBoundary fallback={() => <NotFound />}>
 				<Layout>{props.children}</Layout>
 			</ErrorBoundary>

src/ui/docs-layout.tsx

@@ -1,11 +1,9 @@
 import { Show, onMount, JSX } from "solid-js";
 import { useLocation } from "@solidjs/router";
-import { Title } from "@solidjs/meta";
 import { coreEntries } from "solid:collection";
 import { Pagination } from "~/ui/pagination";
 import { EditPageLink } from "./edit-page-link";
 import { PageIssueLink } from "./page-issue-link";
-import { useProjectTitle } from "./use-project";
 
 interface DocsLayoutProps {
 	entries: typeof coreEntries;
@@ -14,7 +12,6 @@ interface DocsLayoutProps {
 
 export const DocsLayout = (props: DocsLayoutProps) => {
 	const location = useLocation();
-	const projectTitle = useProjectTitle();
 
 	const collection = () =>
 		location.pathname.includes("/reference/")
@@ -41,9 +38,6 @@ export const DocsLayout = (props: DocsLayoutProps) => {
 	return (
 		<Show when={props.entries} keyed>
 			<>
-				<Show when={titles()?.title} fallback={<Title>SolidDocs</Title>}>
-					{(title) => <Title>{`${title()} - ${projectTitle()}`}</Title>}
-				</Show>
 				<article class="expressive-code-overrides mx-auto w-full max-w-2xl overflow-hidden pb-16">
 					<Show when={titles()?.parent}>
 						{(t) => (