From 0f7c45cfed67ad3c0d1336432faad5e71e3a72c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20S=C5=82uszniak?= Date: Mon, 1 Jun 2026 13:54:14 +0200 Subject: [PATCH] fix(ci): gate node_modules diagnostic on existing step id MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 'Show packed node_modules' diagnostic in npm-publish.yml was gated on steps.node_modules.outcome, but no step has id 'node_modules' — the check step is 'check_node_modules'. The condition was always undefined, so the diagnostic never ran and a node_modules leak failed the publish without surfacing the offending paths. Fix the id reference and drop the exit-code inversion so the step reports success after printing matches. --- .github/workflows/npm-publish.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index 466d0f144e..27264ae4e4 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -90,9 +90,8 @@ jobs: - name: Show packed node_modules working-directory: ${{ env.EXECUTORCH_DIR }} - if: failure() && steps.node_modules.outcome == 'failure' - run: >- - ! grep -E "node_modules/.+" build.log + if: failure() && steps.check_node_modules.outcome == 'failure' + run: grep -E "node_modules/.+" build.log - name: Add package name to env working-directory: ${{ env.EXECUTORCH_DIR }}