Refactor/added memory pressure (#799)

mdydek · poneciak57 · web-flow · commit 141c86f5a971 · 2025-11-11T18:08:51.000Z
* feat: implemented alt creeateAsyncPromise and reimplemented Promise

* feat: better promise handling

* refactor: memory pressure added

* refactor: get rid of magic numbers

---------

Co-authored-by: poneciak &lt;poneciak@gmail.com&gt;
diff --git a/packages/react-native-audio-api/common/cpp/audioapi/AudioAPIModuleInstaller.h b/packages/react-native-audio-api/common/cpp/audioapi/AudioAPIModuleInstaller.h
@@ -190,8 +190,12 @@ class AudioAPIModuleInstaller {
               std::make_shared<AudioRecorderHostObject>(
                   audioEventHandlerRegistry, sampleRate, bufferLength);
 
-          return jsi::Object::createFromHostObject(
+          auto jsiObject = jsi::Object::createFromHostObject(
               runtime, audioRecorderHostObject);
+          jsiObject.setExternalMemoryPressure(
+              runtime, sizeof(float) * bufferLength); // rough estimate of underlying buffer
+
+          return jsiObject;
         });
   }
 
diff --git a/packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.cpp b/packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.cpp
@@ -121,7 +121,13 @@ JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createWorkletNode) {
       shouldLockRuntime);
   auto workletNodeHostObject =
       std::make_shared<WorkletNodeHostObject>(workletNode);
-  return jsi::Object::createFromHostObject(runtime, workletNodeHostObject);
+  auto jsiObject =
+      jsi::Object::createFromHostObject(runtime, workletNodeHostObject);
+  jsiObject.setExternalMemoryPressure(
+      runtime,
+      sizeof(float) * bufferLength *
+          inputChannelCount); // rough estimate of underlying buffer
+  return jsiObject;
 #endif
   return jsi::Value::undefined();
 }
@@ -285,6 +291,14 @@ JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createConvolver) {
   }
   auto convolverHostObject =
       std::make_shared<ConvolverNodeHostObject>(convolver);
-  return jsi::Object::createFromHostObject(runtime, convolverHostObject);
+  auto jsiObject =
+      jsi::Object::createFromHostObject(runtime, convolverHostObject);
+  if (!args[0].isUndefined()) {
+    auto bufferHostObject =
+        args[0].getObject(runtime).asHostObject<AudioBufferHostObject>(runtime);
+    jsiObject.setExternalMemoryPressure(
+        runtime, bufferHostObject->getSizeInBytes());
+  }
+  return jsiObject;
 }
 } // namespace audioapi
diff --git a/packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/ConvolverNodeHostObject.cpp b/packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/ConvolverNodeHostObject.cpp
@@ -11,9 +11,8 @@ ConvolverNodeHostObject::ConvolverNodeHostObject(
   addGetters(
       JSI_EXPORT_PROPERTY_GETTER(ConvolverNodeHostObject, normalize),
       JSI_EXPORT_PROPERTY_GETTER(ConvolverNodeHostObject, buffer));
-  addSetters(
-      JSI_EXPORT_PROPERTY_SETTER(ConvolverNodeHostObject, normalize),
-      JSI_EXPORT_PROPERTY_SETTER(ConvolverNodeHostObject, buffer));
+  addSetters(JSI_EXPORT_PROPERTY_SETTER(ConvolverNodeHostObject, normalize));
+  addFunctions(JSI_EXPORT_FUNCTION(ConvolverNodeHostObject, setBuffer));
 }
 
 JSI_PROPERTY_GETTER_IMPL(ConvolverNodeHostObject, normalize) {
@@ -25,23 +24,29 @@ JSI_PROPERTY_GETTER_IMPL(ConvolverNodeHostObject, buffer) {
   auto convolverNode = std::static_pointer_cast<ConvolverNode>(node_);
   auto buffer = convolverNode->getBuffer();
   auto bufferHostObject = std::make_shared<AudioBufferHostObject>(buffer);
-  return jsi::Object::createFromHostObject(runtime, bufferHostObject);
+  auto jsiObject = jsi::Object::createFromHostObject(runtime, bufferHostObject);
+  jsiObject.setExternalMemoryPressure(
+      runtime, bufferHostObject->getSizeInBytes() + 16);
+  return jsiObject;
 }
 
 JSI_PROPERTY_SETTER_IMPL(ConvolverNodeHostObject, normalize) {
   auto convolverNode = std::static_pointer_cast<ConvolverNode>(node_);
   convolverNode->setNormalize(value.getBool());
 }
 
-JSI_PROPERTY_SETTER_IMPL(ConvolverNodeHostObject, buffer) {
+JSI_HOST_FUNCTION_IMPL(ConvolverNodeHostObject, setBuffer) {
   auto convolverNode = std::static_pointer_cast<ConvolverNode>(node_);
-  if (value.isNull()) {
+  if (args[0].isUndefined()) {
     convolverNode->setBuffer(nullptr);
-    return;
+    return jsi::Value::undefined();
   }
 
   auto bufferHostObject =
-      value.getObject(runtime).asHostObject<AudioBufferHostObject>(runtime);
+      args[0].getObject(runtime).asHostObject<AudioBufferHostObject>(runtime);
   convolverNode->setBuffer(bufferHostObject->audioBuffer_);
+  thisValue.asObject(runtime).setExternalMemoryPressure(
+      runtime, bufferHostObject->getSizeInBytes() + 16);
+  return jsi::Value::undefined();
 }
-} // namespace audioapi
+} // namespace audioapi
diff --git a/packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/ConvolverNodeHostObject.h b/packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/ConvolverNodeHostObject.h
@@ -15,6 +15,6 @@ class ConvolverNodeHostObject : public AudioNodeHostObject {
   JSI_PROPERTY_GETTER_DECL(normalize);
   JSI_PROPERTY_GETTER_DECL(buffer);
   JSI_PROPERTY_SETTER_DECL(normalize);
-  JSI_PROPERTY_SETTER_DECL(buffer);
+  JSI_HOST_FUNCTION_DECL(setBuffer);
 };
 } // namespace audioapi
diff --git a/packages/react-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioBufferHostObject.cpp b/packages/react-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioBufferHostObject.cpp
@@ -52,6 +52,8 @@ JSI_HOST_FUNCTION_IMPL(AudioBufferHostObject, getChannelData) {
   auto float32Array = float32ArrayCtor.callAsConstructor(runtime, arrayBuffer)
                           .getObject(runtime);
 
+  float32Array.setExternalMemoryPressure(runtime, audioArrayBuffer->size());
+
   return float32Array;
 }
 
diff --git a/packages/react-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioBufferSourceNodeHostObject.cpp b/packages/react-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioBufferSourceNodeHostObject.cpp
@@ -64,7 +64,10 @@ JSI_PROPERTY_GETTER_IMPL(AudioBufferSourceNodeHostObject, buffer) {
   }
 
   auto bufferHostObject = std::make_shared<AudioBufferHostObject>(buffer);
-  return jsi::Object::createFromHostObject(runtime, bufferHostObject);
+  auto jsiObject = jsi::Object::createFromHostObject(runtime, bufferHostObject);
+  jsiObject.setExternalMemoryPressure(
+      runtime, bufferHostObject->getSizeInBytes() + 16);
+  return jsiObject;
 }
 
 JSI_PROPERTY_GETTER_IMPL(AudioBufferSourceNodeHostObject, loopStart) {
diff --git a/packages/react-native-audio-api/src/core/ConvolverNode.ts b/packages/react-native-audio-api/src/core/ConvolverNode.ts
@@ -19,10 +19,10 @@ export default class ConvolverNode extends AudioNode {
 
   public set buffer(buffer: AudioBuffer | null) {
     if (!buffer) {
-      (this.node as IConvolverNode).buffer = null;
+      (this.node as IConvolverNode).setBuffer(null);
       return;
     }
-    (this.node as IConvolverNode).buffer = buffer.buffer;
+    (this.node as IConvolverNode).setBuffer(buffer.buffer);
   }
 
   public get normalize(): boolean {
diff --git a/packages/react-native-audio-api/src/interfaces.ts b/packages/react-native-audio-api/src/interfaces.ts
@@ -195,8 +195,10 @@ export interface IAudioBufferQueueSourceNode
 }
 
 export interface IConvolverNode extends IAudioNode {
-  buffer: IAudioBuffer | null;
+  readonly buffer: IAudioBuffer | null;
   normalize: boolean;
+
+  setBuffer: (audioBuffer: IAudioBuffer | null) => void;
 }
 
 export interface IAudioBuffer {

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,8 @@ JSI_HOST_FUNCTION_IMPL(AudioBufferHostObject, getChannelData) {`
`52`	`52`	`auto float32Array = float32ArrayCtor.callAsConstructor(runtime, arrayBuffer)`
`53`	`53`	`.getObject(runtime);`
`54`	`54`
	`55`	`+ float32Array.setExternalMemoryPressure(runtime, audioArrayBuffer->size());`
	`56`	`+`
`55`	`57`	`return float32Array;`
`56`	`58`	`}`
`57`	`59`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,10 @@ JSI_PROPERTY_GETTER_IMPL(AudioBufferSourceNodeHostObject, buffer) {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`auto bufferHostObject = std::make_shared<AudioBufferHostObject>(buffer);`
`67`		`- return jsi::Object::createFromHostObject(runtime, bufferHostObject);`
	`67`	`+ auto jsiObject = jsi::Object::createFromHostObject(runtime, bufferHostObject);`
	`68`	`+ jsiObject.setExternalMemoryPressure(`
	`69`	`+ runtime, bufferHostObject->getSizeInBytes() + 16);`
	`70`	`+ return jsiObject;`
`68`	`71`	`}`
`69`	`72`
`70`	`73`	`JSI_PROPERTY_GETTER_IMPL(AudioBufferSourceNodeHostObject, loopStart) {`
Original file line number	Diff line number	Diff line change
`@@ -19,10 +19,10 @@ export default class ConvolverNode extends AudioNode {`
`19`	`19`
`20`	`20`	`public set buffer(buffer: AudioBuffer \| null) {`
`21`	`21`	`if (!buffer) {`
`22`		`- (this.node as IConvolverNode).buffer = null;`
	`22`	`+ (this.node as IConvolverNode).setBuffer(null);`
`23`	`23`	`return;`
`24`	`24`	`}`
`25`		`- (this.node as IConvolverNode).buffer = buffer.buffer;`
	`25`	`+ (this.node as IConvolverNode).setBuffer(buffer.buffer);`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`public get normalize(): boolean {`
Original file line number	Diff line number	Diff line change
`@@ -195,8 +195,10 @@ export interface IAudioBufferQueueSourceNode`
`195`	`195`	`}`
`196`	`196`
`197`	`197`	`export interface IConvolverNode extends IAudioNode {`
`198`		`- buffer: IAudioBuffer \| null;`
	`198`	`+ readonly buffer: IAudioBuffer \| null;`
`199`	`199`	`normalize: boolean;`
	`200`	`+`
	`201`	`+ setBuffer: (audioBuffer: IAudioBuffer \| null) => void;`
`200`	`202`	`}`
`201`	`203`
`202`	`204`	`export interface IAudioBuffer {`