fix(core/schema): set explicit enumerability on error.$response (#1778)

Author: kuhe

.changeset/fifty-oranges-kneel.md

@@ -0,0 +1,5 @@
+---
+"@smithy/core": patch
+---
+
+set explicit enumerability on error.$response

.changeset/fuzzy-goats-hope.md

@@ -0,0 +1,5 @@
+---
+"@smithy/middleware-serde": patch
+---
+
+explicit non-enumerability for error.$response

packages/core/src/submodules/cbor/SmithyRpcV2CborProtocol.ts

@@ -99,7 +99,6 @@ export class SmithyRpcV2CborProtocol extends RpcProtocol {
 
     const errorMetadata = {
       $metadata: metadata,
-      $response: response,
       $fault: response.statusCode <= 500 ? ("client" as const) : ("server" as const),
     };
 

packages/core/src/submodules/schema/middleware/schemaDeserializationMiddleware.ts

@@ -41,6 +41,11 @@ export const schemaDeserializationMiddleware =
       // For security reasons, the error response is not completely visible by default.
       Object.defineProperty(error, "$response", {
         value: response,
+        // we need to define these properties explicitly because
+        // the service exception class may have set the value to undefined, but populated the key.
+        enumerable: false,
+        writable: false,
+        configurable: false,
       });
 
       if (!("$metadata" in error)) {

packages/middleware-serde/src/deserializerMiddleware.ts

@@ -40,6 +40,11 @@ export const deserializerMiddleware =
       // For security reasons, the error response is not completely visible by default.
       Object.defineProperty(error, "$response", {
         value: response,
+        // we need to define these properties explicitly because
+        // the service exception class may have set the value to undefined, but populated the key.
+        enumerable: false,
+        writable: false,
+        configurable: false,
       });
 
       if (!("$metadata" in error)) {