Prevent exceptions being thrown for remaining startForegroundService calls (#1830)

* Change SdlBR handleStartServiceEx access modifier

Update to protected to allow other transport classes to use it

* Add try/catch to RS status class startFrgndService

* Add try/catch to USB Activity startFrgndService

* Add missing space in SDLRSSProvider try block

Co-authored-by: Julian Kast <julian.kast@live.com>

Co-authored-by: Julian Kast <julian.kast@live.com>

Author: joeygrover

android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlBroadcastReceiver.java

@@ -600,7 +600,12 @@ private static boolean isBluetoothConnected() {
         return false;
     }
 
-    private static void handleStartServiceException(Exception e) {
+    /**
+     * Convenience method to log details on the specific exception that occurred while attempting to
+     * start a foreground service.
+     * @param e the exception that occurred
+     */
+    protected static void handleStartServiceException(Exception e) {
         if (e instanceof SecurityException) {
             DebugTool.logError(TAG, "Security exception, process is bad");
             return;

android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlRouterStatusProvider.java

@@ -136,11 +136,21 @@ private boolean bindToService() {
         } else {
             bindingIntent.putExtra(FOREGROUND_EXTRA, true);
             SdlBroadcastReceiver.setForegroundExceptionHandler(); //Prevent ANR in case the OS takes too long to start the service
-            context.startForegroundService(bindingIntent);
+            try {
+                context.startForegroundService(bindingIntent);
+            } catch (SecurityException | IllegalStateException e) {
+                SdlBroadcastReceiver.handleStartServiceException(e);
+            }
 
         }
         bindingIntent.setAction(TransportConstants.BIND_REQUEST_TYPE_STATUS);
-        return context.bindService(bindingIntent, routerConnection, Context.BIND_AUTO_CREATE);
+        boolean didBind = false;
+        try {
+            didBind = context.bindService(bindingIntent, routerConnection, Context.BIND_AUTO_CREATE);
+        } catch (SecurityException | IllegalStateException e) {
+            SdlBroadcastReceiver.handleStartServiceException(e);
+        }
+        return didBind;
     }
 
     private void unBindFromService() {

android/sdl_android/src/main/java/com/smartdevicelink/transport/USBAccessoryAttachmentActivity.java

@@ -202,8 +202,8 @@ public void onUsbTransferUpdate(boolean success) {
 
                         }
 
-                    } catch (SecurityException e) {
-                        DebugTool.logError(TAG, "Security exception, process is bad");
+                    } catch (SecurityException | IllegalStateException e) {
+                        SdlBroadcastReceiver.handleStartServiceException(e);
                     }
                 } else {
                     if (usbAccessory != null) {