Merge pull request #1823 from smartdevicelink/bugfix/issue_1815_ForegroundServiceStartNotAllowedException

Android 12 Catch ForegroundServiceStartNotAllowedException

Author: joeygrover

android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlBroadcastReceiver.java

@@ -34,6 +34,8 @@
 
 import android.app.ActivityManager;
 import android.app.ActivityManager.RunningServiceInfo;
+import android.app.ForegroundServiceStartNotAllowedException;
+import android.app.ServiceStartNotAllowedException;
 import android.bluetooth.BluetoothAdapter;
 import android.bluetooth.BluetoothDevice;
 import android.bluetooth.BluetoothProfile;
@@ -282,8 +284,8 @@ private static void startRouterService(Context context, ComponentName componentN
             restart.putExtra(LOCAL_ROUTER_SERVICE_DID_START_OWN, true);
             context.sendBroadcast(restart);
 
-        } catch (SecurityException e) {
-            DebugTool.logError(TAG, "Security exception, process is bad");
+        } catch (SecurityException | IllegalStateException e) {
+            handleStartServiceException(e);
         }
     }
 
@@ -478,9 +480,8 @@ protected static void pingRouterService(Context context, String packageName, Str
             } else {
                 context.startService(intent);
             }
-        } catch (SecurityException e) {
-            DebugTool.logError(TAG, "Security exception, process is bad");
-            // This service could not be started
+        } catch (SecurityException | IllegalStateException e) {
+            handleStartServiceException(e);
         }
     }
 
@@ -599,6 +600,22 @@ private static boolean isBluetoothConnected() {
         return false;
     }
 
+    private static void handleStartServiceException(Exception e) {
+        if (e instanceof SecurityException) {
+            DebugTool.logError(TAG, "Security exception, process is bad");
+            return;
+        } else if (Build.VERSION.SDK_INT > Build.VERSION_CODES.R) {
+            if (e instanceof ForegroundServiceStartNotAllowedException) {
+                DebugTool.logError(TAG, "Not allowed to start service in foreground");
+                return;
+            } else if (e instanceof ServiceStartNotAllowedException) {
+                DebugTool.logError(TAG, "Not allowed to start service in current state");
+                return;
+            }
+        }
+        DebugTool.logError(TAG, "Unable to start service for unknown reason");
+    }
+
 
     private static SdlDeviceListener getSdlDeviceListener(Context context, BluetoothDevice bluetoothDevice) {