From dfe984922f494886ef40f5a0f1f4dead59d95ac3 Mon Sep 17 00:00:00 2001
From: Beatrycze Volk <beatrycze.volk@slub-dresden.de>
Date: Fri, 26 Jun 2026 13:15:43 +0200
Subject: [PATCH] [MAINTENANCE] Use `getFirstValue()` function

---
 src/Mods/Element/Common/BaseElement.php                   | 2 +-
 src/Mods/Element/Location.php                             | 6 +++---
 src/Mods/Element/Name.php                                 | 2 +-
 .../Specific/Location/HoldingSimple/CopyInformation.php   | 2 +-
 src/Mods/Element/Specific/Part/Extent.php                 | 2 +-
 .../Element/Specific/RecordInfo/LanguageOfCataloging.php  | 4 ++--
 src/Mods/Element/TitleInfo.php                            | 8 ++++----
 src/Mods/Reader/AbstractReader.php                        | 2 +-
 8 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/Mods/Element/Common/BaseElement.php b/src/Mods/Element/Common/BaseElement.php
index 606a412..16c2f1a 100644
--- a/src/Mods/Element/Common/BaseElement.php
+++ b/src/Mods/Element/Common/BaseElement.php
@@ -107,7 +107,7 @@ protected function getLanguageElement(string $xpath): ?LanguageElement
     {
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return new LanguageElement($element->getValues()[0]);
+            return new LanguageElement($element->getFirstValue());
         }
         return null;
     }
diff --git a/src/Mods/Element/Location.php b/src/Mods/Element/Location.php
index 5c9ebbf..bd371eb 100644
--- a/src/Mods/Element/Location.php
+++ b/src/Mods/Element/Location.php
@@ -83,7 +83,7 @@ public function getShelfLocator(string $query = ''): ?LanguageElement
         $xpath = './mods:shelfLocator' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return new LanguageElement($element->getValues()[0]);
+            return new LanguageElement($element->getFirstValue());
         }
         return null;
     }
@@ -124,7 +124,7 @@ public function getHoldingSimple(string $query = ''): ?HoldingSimple
         $xpath = './mods:holdingSimple' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return new HoldingSimple($element->getValues()[0]);
+            return new HoldingSimple($element->getFirstValue());
         }
         return null;
     }
@@ -144,7 +144,7 @@ public function getHoldingExternal(string $query = ''): string
         $xpath = './mods:holdingExternal' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return $element->getValues()[0]->asXML();
+            return $element->getFirstValue()->asXML();
         }
         return '';
     }
diff --git a/src/Mods/Element/Name.php b/src/Mods/Element/Name.php
index 1defdec..15df53f 100644
--- a/src/Mods/Element/Name.php
+++ b/src/Mods/Element/Name.php
@@ -98,7 +98,7 @@ public function getEtal(string $query = ''): ?LanguageElement
         $xpath = './mods:etal' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return new LanguageElement($element->getValues()[0]);
+            return new LanguageElement($element->getFirstValue());
         }
         return null;
     }
diff --git a/src/Mods/Element/Specific/Location/HoldingSimple/CopyInformation.php b/src/Mods/Element/Specific/Location/HoldingSimple/CopyInformation.php
index ab54c00..b72f166 100644
--- a/src/Mods/Element/Specific/Location/HoldingSimple/CopyInformation.php
+++ b/src/Mods/Element/Specific/Location/HoldingSimple/CopyInformation.php
@@ -58,7 +58,7 @@ public function getForm(string $query = ''): ?Form
         $xpath = './mods:form' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return new Form($element->getValues()[0]);
+            return new Form($element->getFirstValue());
         }
         return null;
     }
diff --git a/src/Mods/Element/Specific/Part/Extent.php b/src/Mods/Element/Specific/Part/Extent.php
index dceb611..a54756a 100644
--- a/src/Mods/Element/Specific/Part/Extent.php
+++ b/src/Mods/Element/Specific/Part/Extent.php
@@ -97,7 +97,7 @@ public function getTotal(string $query = ''): int
         $xpath = './mods:total' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return (int) $element->getValues()[0];
+            return (int) $element->getFirstValue();
         }
         return 0;
     }
diff --git a/src/Mods/Element/Specific/RecordInfo/LanguageOfCataloging.php b/src/Mods/Element/Specific/RecordInfo/LanguageOfCataloging.php
index cc3a56a..adc2c4a 100644
--- a/src/Mods/Element/Specific/RecordInfo/LanguageOfCataloging.php
+++ b/src/Mods/Element/Specific/RecordInfo/LanguageOfCataloging.php
@@ -73,7 +73,7 @@ public function getLanguageTerm(string $query = ''): ?LanguageTerm
         $xpath = './mods:languageTerm' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return new LanguageTerm($element->getValues()[0]);
+            return new LanguageTerm($element->getFirstValue());
         }
         return null;
     }
@@ -93,7 +93,7 @@ public function getScriptTerm(string $query = ''): ?ScriptTerm
         $xpath = './mods:scriptTerm' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return new ScriptTerm($element->getValues()[0]);
+            return new ScriptTerm($element->getFirstValue());
         }
         return null;
     }
diff --git a/src/Mods/Element/TitleInfo.php b/src/Mods/Element/TitleInfo.php
index 742b47b..267f206 100644
--- a/src/Mods/Element/TitleInfo.php
+++ b/src/Mods/Element/TitleInfo.php
@@ -101,7 +101,7 @@ public function getTitle(string $query = ''): ?LanguageElement
         $xpath = './mods:title' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return new LanguageElement($element->getValues()[0]);
+            return new LanguageElement($element->getFirstValue());
         }
         return null;
     }
@@ -121,7 +121,7 @@ public function getSubTitle(string $query = ''): ?LanguageElement
         $xpath = './mods:subTitle' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return new LanguageElement($element->getValues()[0]);
+            return new LanguageElement($element->getFirstValue());
         }
         return null;
     }
@@ -141,7 +141,7 @@ public function getPartNumber(string $query = ''): ?LanguageElement
         $xpath = './mods:partNumber' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return new LanguageElement($element->getValues()[0]);
+            return new LanguageElement($element->getFirstValue());
         }
         return null;
     }
@@ -181,7 +181,7 @@ public function getNonSort(string $query = ''): ?NonSort
         $xpath = './mods:nonSort' . $query;
         $element = new Element($this->xml, $xpath);
         if ($element->exists()) {
-            return new NonSort($element->getValues()[0]);
+            return new NonSort($element->getFirstValue());
         }
         return null;
     }
diff --git a/src/Mods/Reader/AbstractReader.php b/src/Mods/Reader/AbstractReader.php
index bbdd053..1448dae 100644
--- a/src/Mods/Reader/AbstractReader.php
+++ b/src/Mods/Reader/AbstractReader.php
@@ -59,7 +59,7 @@ public function getAbstractByParameters(string $query = '', array $attributes =
         $query = new Query('./mods:abstract', $query, $attributes, $value);
         $element = new Element($this->xml, $query->getXPath());
         if ($element->exists()) {
-            return new AbstractElement($element->getValues()[0]);
+            return new AbstractElement($element->getFirstValue());
         }
         return null;
     }