Skip to content

Commit a1886c9

Browse files
committed
Don't test log/unstable_kv feature on the MSRV
Due to its unstable feature, it requires a recent compiler and we cannot reasonably make MSRV guarentees for their project. Add disclaimer about this to the Cargo.toml file
1 parent 7a93747 commit a1886c9

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

.github/workflows/test.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ jobs:
2929
fail-fast: false # Even if one job fails we still want to see the other ones
3030
matrix:
3131
# 1.39 is MSRV. Keep in sync with Cargo.toml
32+
#
33+
# There are no MSRV guarentees for the kv_unstable feature.
34+
# See `Cargo.toml` for more details.
3235
rust: [1.39, stable, nightly]
3336
# NOTE: Features to test must be specified manually. They are applied to all versions seperately.
3437
#
@@ -37,6 +40,9 @@ jobs:
3740
#
3841
# Specific feature combos can be overriden per-version with 'include' and 'exclude'
3942
features: ["", "kv_unstable"]
43+
exclude:
44+
- rust: 1.39 # MSRV (see above)
45+
features: "kv_unstable"
4046

4147
steps:
4248
- uses: actions/checkout@v2

Cargo.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ edition = "2018"
2121
#
2222
# The first version of Cargo that supports this field was in Rust 1.56.0.
2323
# In older releases, the field will be ignored, and Cargo will display a warning.
24+
#
25+
# DISCLAIMER:
26+
# The log/kv_unstable feature requires a recent (stable) compiler.
27+
# It will not compile with this claimed MSRV and requires a recent (stable) compiler.
2428
rust-version = "1.38"
2529

2630
[lib]

0 commit comments

Comments
 (0)