From 398d5ca6e0cabec7155749700b4dd3c7a8f4450a Mon Sep 17 00:00:00 2001 From: Pushkar Banjare Date: Mon, 15 Jun 2026 00:14:18 +0530 Subject: [PATCH 1/4] added export for 'addAppMetadata' --- packages/webhook/package.json | 4 ++-- packages/webhook/src/index.ts | 2 ++ packages/webhook/src/instrument.test.ts | 16 ++++++++++++++++ 3 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 packages/webhook/src/instrument.test.ts diff --git a/packages/webhook/package.json b/packages/webhook/package.json index b9f8f6fb8..6ccc68eda 100644 --- a/packages/webhook/package.json +++ b/packages/webhook/package.json @@ -37,8 +37,8 @@ "build:clean": "shx rm -rf ./dist", "docs": "npx typedoc --plugin typedoc-plugin-markdown", "prepack": "npm run build", - "test": "npm run build && node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/IncomingWebhook.test.ts", - "test:coverage": "npm run build && node --experimental-test-coverage --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=lcov.info --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/IncomingWebhook.test.ts" + "test": "npm run build && node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/*.test.ts", + "test:coverage": "npm run build && node --experimental-test-coverage --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=lcov.info --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/*.test.ts" }, "dependencies": { "@slack/types": "^2.20.1", diff --git a/packages/webhook/src/index.ts b/packages/webhook/src/index.ts index 74420ffba..8c3183fed 100644 --- a/packages/webhook/src/index.ts +++ b/packages/webhook/src/index.ts @@ -14,3 +14,5 @@ export { IncomingWebhookResult, IncomingWebhookSendArguments, } from './IncomingWebhook'; + +export {addAppMetadata} from './instrument'; \ No newline at end of file diff --git a/packages/webhook/src/instrument.test.ts b/packages/webhook/src/instrument.test.ts new file mode 100644 index 000000000..0b2e8380c --- /dev/null +++ b/packages/webhook/src/instrument.test.ts @@ -0,0 +1,16 @@ +import assert from 'node:assert/strict'; +import { describe, it } from 'node:test'; + +import { addAppMetadata } from './index'; +import { getUserAgent } from './instrument'; + +describe('@slack/webhook public exports', () => { + it('exposes a working addAppMetadata from the package entry point', () => { + // addAppMetadata must be reachable from the package's public API (./index) and the instrument function. + addAppMetadata({ name: '@slack/slack-github-action', version: '3.0.3' }); + assert.ok( + getUserAgent().includes('@slack:slack-github-action/3.0.3'), + 'addAppMetadata re-exported from ./index should affect the User-Agent', + ); + }); +}); \ No newline at end of file From 27dda267b06447366ba2e0979024647e1b80a3ea Mon Sep 17 00:00:00 2001 From: Ale Mercado Date: Tue, 16 Jun 2026 12:50:32 -0400 Subject: [PATCH 2/4] add changeset for webhook addAppMetadata export --- .changeset/export-add-app-metadata.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/export-add-app-metadata.md diff --git a/.changeset/export-add-app-metadata.md b/.changeset/export-add-app-metadata.md new file mode 100644 index 000000000..26b26103a --- /dev/null +++ b/.changeset/export-add-app-metadata.md @@ -0,0 +1,5 @@ +--- +"@slack/webhook": minor +--- + +feat: export `addAppMetadata` for external instrumentation use From 5fd1a17cde82bd3f932f1e33ce7723b54e1a7927 Mon Sep 17 00:00:00 2001 From: Ale Mercado Date: Tue, 16 Jun 2026 12:55:30 -0400 Subject: [PATCH 3/4] linter --- packages/webhook/src/index.ts | 2 +- packages/webhook/src/instrument.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/webhook/src/index.ts b/packages/webhook/src/index.ts index 8c3183fed..ce68a73e7 100644 --- a/packages/webhook/src/index.ts +++ b/packages/webhook/src/index.ts @@ -15,4 +15,4 @@ export { IncomingWebhookSendArguments, } from './IncomingWebhook'; -export {addAppMetadata} from './instrument'; \ No newline at end of file +export { addAppMetadata } from './instrument'; diff --git a/packages/webhook/src/instrument.test.ts b/packages/webhook/src/instrument.test.ts index 0b2e8380c..ef998fc83 100644 --- a/packages/webhook/src/instrument.test.ts +++ b/packages/webhook/src/instrument.test.ts @@ -13,4 +13,4 @@ describe('@slack/webhook public exports', () => { 'addAppMetadata re-exported from ./index should affect the User-Agent', ); }); -}); \ No newline at end of file +}); From ae5637ae22e4458f70e85ea1ccad1d52e86a3fd8 Mon Sep 17 00:00:00 2001 From: Ale Mercado Date: Tue, 16 Jun 2026 13:11:42 -0400 Subject: [PATCH 4/4] tests --- packages/webhook/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/webhook/package.json b/packages/webhook/package.json index 6ccc68eda..7be1c6771 100644 --- a/packages/webhook/package.json +++ b/packages/webhook/package.json @@ -37,8 +37,8 @@ "build:clean": "shx rm -rf ./dist", "docs": "npx typedoc --plugin typedoc-plugin-markdown", "prepack": "npm run build", - "test": "npm run build && node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/*.test.ts", - "test:coverage": "npm run build && node --experimental-test-coverage --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=lcov.info --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/*.test.ts" + "test": "npm run build && node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/IncomingWebhook.test.ts src/instrument.test.ts", + "test:coverage": "npm run build && node --experimental-test-coverage --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=lcov.info --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/IncomingWebhook.test.ts src/instrument.test.ts" }, "dependencies": { "@slack/types": "^2.20.1",