Skip to content

[ENH] EXPERIMENTAL PR: make the data_module dataclass-like #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2025
Merged

[ENH] EXPERIMENTAL PR: make the data_module dataclass-like #1832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2c34aa
try to make dataclass-like
phoeenniixx May 13, 2025
01ebacd
Merge branch 'main' into dataclass
phoeenniixx May 16, 2025
ef47aa8
Merge branch 'main' into dataclass
phoeenniixx May 17, 2025
5ae6e51
remove the commented out block
phoeenniixx May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions pytorch_forecasting/data/data_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,6 @@ def __init__(
else:
self.continuous_indices.append(idx)

# overwrite __init__ params for upwards compatibility with AS PRs
# todo: should we avoid this and ensure classes are dataclass-like?
self.min_prediction_length = self._min_prediction_length
self.min_encoder_length = self._min_encoder_length
self.categorical_encoders = self._categorical_encoders
self.scalers = self._scalers
self.target_normalizer = self._target_normalizer

def _prepare_metadata(self):
"""Prepare metadata for model initialisation.

Expand Down
4 changes: 2 additions & 2 deletions tests/test_data/test_data_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ def test_init(sample_timeseries_data):

assert dm.max_encoder_length == 24
assert dm.max_prediction_length == 12
assert dm.min_encoder_length == 24
assert dm.min_prediction_length == 12
assert dm._min_encoder_length == 24
assert dm._min_prediction_length == 12
assert dm.batch_size == 8
assert dm.train_val_test_split == (0.7, 0.15, 0.15)

Expand Down
Loading