Skip to content

Commit 7bad955

Browse files
jeffdailyskarjala
authored andcommitted
[ROCm][CD] upgrade to 6.4.1 patch release (pytorch#156636)
During pytorch#156112, we missed upgrading the manylinux and libtorch docker images. Fixes pytorch#155292 Pull Request resolved: pytorch#156636 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
1 parent 491079c commit 7bad955

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

.ci/docker/common/install_rocm_magma.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,12 @@ set -eou pipefail
55

66
function do_install() {
77
rocm_version=$1
8-
rocm_version_nodot=${1//./}
8+
if [[ ${rocm_version} =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
9+
# chop off any patch version
10+
rocm_version="${rocm_version%.*}"
11+
fi
12+
13+
rocm_version_nodot=${rocm_version//./}
914

1015
# Version 2.7.2 + ROCm related updates
1116
MAGMA_VERSION=a1625ff4d9bc362906bd01f805dbbe12612953f6

.ci/docker/libtorch/build.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ case ${DOCKER_TAG_PREFIX} in
3939
DOCKER_GPU_BUILD_ARG=""
4040
;;
4141
rocm*)
42+
# we want the patch version of 6.4 instead
43+
if [[ $(ver $GPU_ARCH_VERSION) -eq $(ver 6.4) ]]; then
44+
GPU_ARCH_VERSION="${GPU_ARCH_VERSION}.1"
45+
fi
4246
BASE_TARGET=rocm
4347
GPU_IMAGE=rocm/dev-ubuntu-22.04:${GPU_ARCH_VERSION}-complete
4448
PYTORCH_ROCM_ARCH="gfx900;gfx906;gfx908;gfx90a;gfx942;gfx1030;gfx1100;gfx1101;gfx1102;gfx1200;gfx1201"

.ci/docker/manywheel/build.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,10 @@ case ${image} in
7575
DOCKERFILE_SUFFIX="_cuda_aarch64"
7676
;;
7777
manylinux2_28-builder:rocm*)
78+
# we want the patch version of 6.4 instead
79+
if [[ $(ver $GPU_ARCH_VERSION) -eq $(ver 6.4) ]]; then
80+
GPU_ARCH_VERSION="${GPU_ARCH_VERSION}.1"
81+
fi
7882
TARGET=rocm_final
7983
MANY_LINUX_VERSION="2_28"
8084
DEVTOOLSET_VERSION="11"

0 commit comments

Comments
 (0)