fix(workflows): check JSON editors sent under a canonical param

Author: waleedlatif1

apps/sim/lib/workflows/application/deployments.ts

@@ -102,7 +102,9 @@ async function requireMutableWorkflow(workflowId: string): Promise<void> {
 }
 
 /**
- * The lint findings of the version a deploy just made live, as one warning.
+ * The lint findings of the version a deploy admitted, as one warning. That
+ * version serves callers once activation completes, so it is linted even while
+ * activation is still pending.
  *
  * Deploy does not refuse on lint: findings are advisory, and some depend on the
  * identity that runs the workflow. But a caller that deployed without linting
@@ -127,7 +129,7 @@ async function deployedVersionLintWarning(
       )
     )
     if (!hasWorkflowLintIssues(report)) return undefined
-    return `The deployed version has lint findings and may fail when it runs. ${formatWorkflowLintMessage(report)}`
+    return `The version this deploy publishes has lint findings and may fail when it runs. ${formatWorkflowLintMessage(report)}`
   } catch (error) {
     logger.warn('Deployed version lint failed', {
       workflowId: context.workflowId,

apps/sim/lib/workflows/editing/json-literal-refs.test.ts

@@ -38,6 +38,19 @@ const MOCK_BLOCKS = vi.hoisted(
             condition: { field: 'operation', value: ['insert_row', 'update_row'] },
           },
           { id: 'rows', type: 'code', language: 'json' },
+          {
+            id: 'filterBuilder',
+            type: 'filter-builder',
+            canonicalParamId: 'filterInput',
+            mode: 'basic',
+          },
+          {
+            id: 'filter',
+            type: 'code',
+            language: 'json',
+            canonicalParamId: 'filterInput',
+            mode: 'advanced',
+          },
         ],
         outputs: {},
       },
@@ -87,7 +100,10 @@ const START = {
 }
 
 function graph(
-  blocks: Record<string, { type?: string; name?: string; subBlocks?: Record<string, unknown> }>
+  blocks: Record<
+    string,
+    { type?: string; name?: string; subBlocks?: Record<string, unknown>; data?: unknown }
+  >
 ) {
   return { blocks } as Parameters<typeof collectUnquotedJsonStringReferences>[0]
 }
@@ -215,4 +231,22 @@ describe('collectUnquotedJsonStringReferences', () => {
     )
     expect(findings).toHaveLength(0)
   })
+
+  it('checks a JSON editor that is sent under its canonical parameter', () => {
+    const findings = collectUnquotedJsonStringReferences(
+      graph({
+        start: START,
+        query: {
+          type: 'table_v2',
+          name: 'Find Order',
+          data: { canonicalModes: { filterInput: 'advanced' } },
+          subBlocks: {
+            operation: { value: 'query_rows' },
+            filter: { value: '{"field": "order_id", "op": "eq", "value": <start.order_id>}' },
+          },
+        },
+      })
+    )
+    expect(findings).toMatchObject([{ blockId: 'query', field: 'filter' }])
+  })
 })

apps/sim/lib/workflows/editing/lint.ts

@@ -799,15 +799,21 @@ export function collectUnquotedJsonStringReferences(
       (subBlock) => subBlock.type === 'code' && subBlock.language === 'json'
     )
     if (!jsonFields?.length) continue
-    /** Only what the serializer sends: a field the selected operation drops never runs. */
+    /**
+     * Only what the serializer sends: a field the selected operation or mode
+     * drops never runs, and a canonical member is sent under its canonical id.
+     */
     let params: Record<string, unknown>
     try {
       params = extractBlockParams(block as Parameters<typeof extractBlockParams>[0])
     } catch {
       continue
     }
-    for (const field of new Set(jsonFields.map((subBlock) => subBlock.id))) {
-      const json = params[field]
+    const sentParamByField = new Map(
+      jsonFields.map((subBlock) => [subBlock.id, subBlock.canonicalParamId ?? subBlock.id])
+    )
+    for (const [field, param] of sentParamByField) {
+      const json = params[param]
       if (typeof json !== 'string') continue
       const unquoted = new Set<string>()
       for (const token of unquotedJsonReferenceTokens(json)) {