fix(ironclad): address PR review comments - add required constraint, defensive response parsing

waleedlatif1 · waleedlatif1 · commit eca34502bb97 · 2026-03-26T15:33:37.000-07:00
diff --git a/apps/sim/blocks/blocks/ironclad.ts b/apps/sim/blocks/blocks/ironclad.ts
@@ -163,6 +163,7 @@ export const IroncladBlock: BlockConfig = {
       type: 'long-input',
       placeholder: '{"counterpartyName": {"type": "string", "value": "Acme Corp"}}',
       condition: { field: 'operation', value: ['create_record', 'update_record'] },
+      required: { field: 'operation', value: 'update_record' },
       wandConfig: {
         enabled: true,
         prompt:
diff --git a/apps/sim/tools/ironclad/list_workflow_comments.ts b/apps/sim/tools/ironclad/list_workflow_comments.ts
@@ -53,7 +53,7 @@ export const listWorkflowCommentsTool: ToolConfig<
     return {
       success: true,
       output: {
-        comments: data ?? [],
+        comments: data.list ?? data.comments ?? data ?? [],
       },
     }
   },
diff --git a/apps/sim/tools/ironclad/list_workflows.ts b/apps/sim/tools/ironclad/list_workflows.ts
@@ -72,7 +72,7 @@ export const listWorkflowsTool: ToolConfig<
       output: {
         workflows,
         page: data.page ?? 0,
-        pageSize: data.pageSize ?? 20,
+        pageSize: data.pageSize ?? data.perPage ?? 20,
         count: data.count ?? 0,
       },
     }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ export const listWorkflowCommentsTool: ToolConfig<`
`53`	`53`	`return {`
`54`	`54`	`success: true,`
`55`	`55`	`output: {`
`56`		`- comments: data ?? [],`
	`56`	`+ comments: data.list ?? data.comments ?? data ?? [],`
`57`	`57`	`},`
`58`	`58`	`}`
`59`	`59`	`},`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ export const listWorkflowsTool: ToolConfig<`
`72`	`72`	`output: {`
`73`	`73`	`workflows,`
`74`	`74`	`page: data.page ?? 0,`
`75`		`- pageSize: data.pageSize ?? 20,`
	`75`	`+ pageSize: data.pageSize ?? data.perPage ?? 20,`
`76`	`76`	`count: data.count ?? 0,`
`77`	`77`	`},`
`78`	`78`	`}`