fix(oracle-epm-planning): address CI contracts and registration checks

Author: Bill Leoutsakos

apps/sim/blocks/blocks/oracle_epm_planning.ts

@@ -1698,7 +1698,7 @@ export const OracleEpmPlanningBlock: BlockConfig<OracleEpmPlanningResponse> = {
   },
 }
 export const OracleEpmPlanningBlockMeta = {
-  tags: ['automation', 'data-analytics', 'finance'],
+  tags: ['automation', 'data-analytics'],
   url: 'https://www.oracle.com/performance-management/planning/',
   templates: [
     {

apps/sim/lib/integrations/credential-display.test.ts

@@ -68,6 +68,7 @@ const EXPECTED_COVERAGE: Record<string, string[]> = {
   // NetSuite remains an API-key catalog integration, like Snowflake, while its
   // block uses the shared reusable-credential selector.
   'netsuite-service-account': [],
+  'oracle-epm-service-account': [],
   'pipedrive-service-account': ['pipedrive'],
   'salesforce-service-account': ['salesforce'],
   'shopify-service-account': ['shopify'],

apps/sim/lib/internal/oracle-epm-planning/execute-tool.test.ts

@@ -720,7 +720,7 @@ const CASES: {
 
 async function invoke(operation: string, input: Record<string, unknown>, signal?: AbortSignal) {
   const response = await executeOracleEpmPlanningTool({
-    toolId: 'oracle_epm_planning_' + operation,
+    toolId: `oracle_epm_planning_${operation}`,
     input: { ...AUTH, ...input },
     headers: new Headers(),
     context: { userId: 'user-1', workflowId: 'workflow-1' },
@@ -817,7 +817,7 @@ describe('Planning operation contracts through the real foundation', () => {
     expect(result.success, JSON.stringify(result)).toBe(true)
     expect(result.output).toHaveProperty(entry.output)
     expect(mocks.fetch).toHaveBeenCalledTimes(1)
-    const [url, options] = mocks.fetch.mock.calls[0]
+    const [url, , options] = mocks.fetch.mock.calls[0]
     expect(new URL(url).pathname).toBe(entry.path)
     expect(Object.fromEntries(new URL(url).searchParams)).toEqual(entry.query ?? {})
     expect(options.method).toBe(entry.method)

apps/sim/lib/internal/oracle-epm-planning/files.server.test.ts

@@ -282,6 +282,28 @@ describe('Planning file orchestration over foundation primitives', () => {
       expect(request.mock.calls.at(-1)?.[0]).toBe(planningEndpoints.cleanupDownload)
     }
   )
+  it.each([false, true])(
+    'reports cleanup failure without replacing a prior storage failure (%s)',
+    async (storageFailed) => {
+      startDownload()
+      const originalRequest = request.getMockImplementation()!
+      request.mockImplementation(async (endpoint, input) => {
+        if (endpoint === planningEndpoints.cleanupDownload) throw new Error('Cleanup unavailable')
+        return originalRequest(endpoint, input)
+      })
+      const storageError = new Error('Storage unavailable')
+      if (storageFailed) mocks.store.mockRejectedValue(storageError)
+      const download = downloadPlanningFile({ ...auth, fileName: 'data.csv' }, context)
+      if (storageFailed) {
+        await expect(download).rejects.toBe(storageError)
+      } else {
+        await expect(download).rejects.toThrow(
+          'File was stored, but Oracle temporary download cleanup failed'
+        )
+      }
+      expect(request.mock.calls.at(-1)?.[0]).toBe(planningEndpoints.cleanupDownload)
+    }
+  )
   it('attempts cleanup after polling cancellation with a fresh bounded signal', async () => {
     startDownload()
     const controller = new AbortController()

apps/sim/lib/internal/oracle-epm-planning/files.server.ts

@@ -6,7 +6,7 @@ import {
   openOracleEpmSourceFile,
   storeOracleEpmDownload,
 } from '@/lib/internal/oracle-epm/files.server'
-import { pollOracleEpmJob } from '@/lib/internal/oracle-epm/jobs'
+import { type OracleEpmPollClassification, pollOracleEpmJob } from '@/lib/internal/oracle-epm/jobs'
 import {
   PLANNING_DOWNLOAD_BYTES,
   PLANNING_INPUT_FILE_BYTES,
@@ -39,7 +39,9 @@ function findLink(status: InteropStatus, rel: string) {
   return links[0]
 }
 
-function interopClassification(status: InteropStatus) {
+function interopClassification(
+  status: InteropStatus
+): OracleEpmPollClassification<InteropStatus, InteropStatus> {
   if (status.status === -1) return { state: 'pending' } as const
   if (status.status === 0) return { state: 'success', result: status } as const
   return { state: 'failure', error: status } as const
@@ -185,11 +187,15 @@ export async function downloadPlanningFile(
   }
   const maxWaitMs = (input.maxWaitSeconds ?? 300) * 1000
   const deadlineAt = new Date(
-    Math.min(Date.now() + maxWaitMs, getExecutionDeadlineAt(context.signal)?.getTime() ?? Infinity)
+    Math.min(
+      Date.now() + maxWaitMs,
+      getExecutionDeadlineAt(context.signal)?.getTime() ?? Number.POSITIVE_INFINITY
+    )
   )
   let temporaryJobId: string | undefined
   let body: ReadableStream<Uint8Array> | undefined
-  let operationFailed = true
+  let file: UserFile
+  let cleanupFailed = false
   try {
     const initiation = parsePlanningResponse(
       interopStatusSchema,
@@ -236,7 +242,7 @@ export async function downloadPlanningFile(
     if (response.contentType?.split(';')[0].trim().toLowerCase() === 'application/json') {
       throw new PlanningInputError('Oracle returned an error instead of downloadable file content')
     }
-    const file = await storeOracleEpmDownload({
+    file = await storeOracleEpmDownload({
       body,
       fileName: input.fileName,
       contentType: response.contentType,
@@ -245,8 +251,6 @@ export async function downloadPlanningFile(
       maxBytes: PLANNING_DOWNLOAD_BYTES,
       signal: context.signal,
     })
-    operationFailed = false
-    return file
   } catch (error) {
     if (error instanceof PayloadSizeLimitError) {
       throw new PlanningInputError(
@@ -269,11 +273,12 @@ export async function downloadPlanningFile(
       } catch {
         /** Preserve an earlier failure, and never include tenant identifiers or response bodies in logs. */
         logger.warn('Oracle temporary download cleanup failed')
-        if (!operationFailed)
-          throw new PlanningInputError(
-            'File was stored, but Oracle temporary download cleanup failed'
-          )
+        cleanupFailed = true
       }
     }
   }
+  if (cleanupFailed) {
+    throw new PlanningInputError('File was stored, but Oracle temporary download cleanup failed')
+  }
+  return file
 }

apps/sim/lib/internal/oracle-epm-planning/jobs.ts

@@ -1,5 +1,5 @@
 import { z } from 'zod'
-import { pollOracleEpmJob } from '@/lib/internal/oracle-epm/jobs'
+import { type OracleEpmPollClassification, pollOracleEpmJob } from '@/lib/internal/oracle-epm/jobs'
 import { planningEndpoints } from '@/lib/internal/oracle-epm-planning/route-space'
 import {
   jobSchema,
@@ -14,7 +14,9 @@ import type {
 } from '@/tools/oracle_epm_planning/types'
 
 /** https://docs.oracle.com/en/cloud/saas/enterprise-performance-management-common/prest/retrieve_job_status.html */
-export function classifyPlanningJob(job: PlanningJob) {
+export function classifyPlanningJob(
+  job: PlanningJob
+): OracleEpmPollClassification<PlanningJob, PlanningJob> {
   if (job.status === -1 || job.status === 2) return { state: 'pending' } as const
   if (job.status === 0) return { state: 'success', result: job } as const
   return { state: 'failure', error: job } as const

apps/sim/lib/internal/oracle-epm-planning/operations/download-file.ts

@@ -1,5 +1,5 @@
 import { downloadPlanningFile } from '@/lib/internal/oracle-epm-planning/files.server'
-import { type PlanningOperationContext } from '@/lib/internal/oracle-epm-planning/schema'
+import type { PlanningOperationContext } from '@/lib/internal/oracle-epm-planning/schema'
 import type {
   OracleEpmPlanningDownloadFileParams,
   OracleEpmPlanningResponse,

apps/sim/lib/internal/oracle-epm-planning/operations/export-application-data.ts

@@ -3,7 +3,7 @@ import {
   submitPlanningJob,
   validatePlanningJobParameters,
 } from '@/lib/internal/oracle-epm-planning/jobs'
-import { type PlanningOperationContext } from '@/lib/internal/oracle-epm-planning/schema'
+import type { PlanningOperationContext } from '@/lib/internal/oracle-epm-planning/schema'
 import type {
   OracleEpmPlanningExportApplicationDataParams,
   OracleEpmPlanningResponse,

apps/sim/lib/internal/oracle-epm-planning/operations/get-job.ts

@@ -1,5 +1,5 @@
 import { readPlanningJob } from '@/lib/internal/oracle-epm-planning/jobs'
-import { type PlanningOperationContext } from '@/lib/internal/oracle-epm-planning/schema'
+import type { PlanningOperationContext } from '@/lib/internal/oracle-epm-planning/schema'
 import type {
   OracleEpmPlanningGetJobParams,
   OracleEpmPlanningResponse,

apps/sim/lib/internal/oracle-epm-planning/operations/import-application-data.ts

@@ -3,7 +3,7 @@ import {
   submitPlanningJob,
   validatePlanningJobParameters,
 } from '@/lib/internal/oracle-epm-planning/jobs'
-import { type PlanningOperationContext } from '@/lib/internal/oracle-epm-planning/schema'
+import type { PlanningOperationContext } from '@/lib/internal/oracle-epm-planning/schema'
 import type {
   OracleEpmPlanningImportApplicationDataParams,
   OracleEpmPlanningResponse,