ci: clear the dev cache by absolute path, always run session cleanup, floor shard weights, log through @sim/logger

Author: waleedlatif1

.github/workflows/checks.yml

@@ -328,15 +328,19 @@ jobs:
           cache_broken() {
             grep -qiE 'cache corruption|turbopack.*panic|panicked' "$next_log" 2>/dev/null
           }
-          # The cache directory is a mount point: empty it rather than remove it.
+          # The cache directory is a mount point: empty it rather than remove it. Absolute, because
+          # the EXIT trap runs after the step has moved into apps/desktop.
           clear_cache() {
-            find apps/sim/.next/dev -mindepth 1 -maxdepth 1 -exec rm -rf {} +
+            find "$GITHUB_WORKSPACE/apps/sim/.next/dev" -mindepth 1 -maxdepth 1 -exec rm -rf {} +
           }
           # SIGINT first: `next dev` SIGKILLs its server 100ms after SIGTERM, which discards a cache
           # write in flight. stop-session.sh then removes anything still running.
+          # SIGINT is best-effort; the cleanup always runs, since workers and the detached telemetry
+          # flush can outlive a server that has already exited.
           stop_sim() {
-            kill -INT "$server_pid" 2>/dev/null || return 0
-            for _ in $(seq 1 30); do kill -0 "$server_pid" 2>/dev/null || break; sleep 1; done
+            if kill -INT "$server_pid" 2>/dev/null; then
+              for _ in $(seq 1 30); do kill -0 "$server_pid" 2>/dev/null || break; sleep 1; done
+            fi
             bash "$GITHUB_WORKSPACE/.github/scripts/stop-session.sh" "$server_pid" "$server_tag"
           }
           (cd apps/realtime && PORT=3023 SIM_DB_ROLE=realtime ALLOWED_ORIGINS="$NEXT_PUBLIC_APP_URL" \

scripts/update-integration-durations.ts

@@ -14,11 +14,13 @@
  */
 import { readdir, readFile, writeFile } from 'node:fs/promises'
 import path from 'node:path'
+import { createLogger } from '@sim/logger'
 
 interface JsonReport {
   testResults: { name: string; startTime: number; endTime: number }[]
 }
 
+const logger = createLogger('UpdateIntegrationDurations')
 const REPORT_NAME = 'integration.json'
 const ROOT = path.resolve(import.meta.dir, '..')
 const OUTPUT = path.join(ROOT, 'vitest.integration-durations.json')
@@ -38,7 +40,7 @@ function repoPath(absolute: string): string | null {
 
 const source = process.argv[2]
 if (!source) {
-  console.error('Usage: bun run scripts/update-integration-durations.ts <downloaded-reports-dir>')
+  logger.error('Usage: bun run scripts/update-integration-durations.ts <downloaded-reports-dir>')
   process.exit(1)
 }
 
@@ -62,7 +64,7 @@ for (const reportPath of reports) {
 }
 
 if (samples.size === 0) {
-  console.error(`No ${REPORT_NAME} reports with test results under ${source}`)
+  logger.error(`No ${REPORT_NAME} reports with test results under ${source}`)
   process.exit(1)
 }
 
@@ -74,4 +76,4 @@ const durations = Object.fromEntries(
   })
 )
 await writeFile(OUTPUT, `${JSON.stringify(durations, null, 2)}\n`)
-console.log(`Wrote ${samples.size} file weights from ${reports.length} reports to ${OUTPUT}`)
+logger.info(`Wrote ${samples.size} file weights from ${reports.length} reports to ${OUTPUT}`)

vitest.shared.ts

@@ -27,6 +27,8 @@ export default defineConfig({
 
 /** Seconds a file of unknown duration is assumed to take: about the median measured file. */
 const UNKNOWN_FILE_SECONDS = 6
+/** Floor for any file: one that skips every test in CI still pays its import and collection. */
+const MIN_FILE_SECONDS = 1
 const DURATIONS_FILE = 'vitest.integration-durations.json'
 
 function findRepoRoot(from: string): string {
@@ -63,7 +65,11 @@ class DurationBalancedSequencer extends BaseSequencer {
 
     const weighted = files.map((spec) => {
       const key = path.relative(root, spec.moduleId).split(path.sep).join('/')
-      return { spec, key, seconds: durations[key] ?? UNKNOWN_FILE_SECONDS }
+      return {
+        spec,
+        key,
+        seconds: Math.max(durations[key] ?? UNKNOWN_FILE_SECONDS, MIN_FILE_SECONDS),
+      }
     })
     weighted.sort((a, b) => b.seconds - a.seconds || (a.key < b.key ? -1 : a.key > b.key ? 1 : 0))